Pipeline.indexOf(Step) returns -1 if not present#782
Merged
SamCarlberg merged 1 commit intoWPIRoboticsProjects:masterfrom Jan 12, 2017
Merged
Pipeline.indexOf(Step) returns -1 if not present#782SamCarlberg merged 1 commit intoWPIRoboticsProjects:masterfrom
SamCarlberg merged 1 commit intoWPIRoboticsProjects:masterfrom
Conversation
Current coverage is 52.16% (diff: 50.00%)@@ master #782 diff @@
==========================================
Files 238 238
Lines 7671 7668 -3
Methods 0 0
Messages 0 0
Branches 739 739
==========================================
- Hits 4012 4000 -12
- Misses 3478 3484 +6
- Partials 181 184 +3
|
Instead of throwing an exception. Threading stuff kills it. Fixes WPIRoboticsProjects#781
JLLeitschuh
approved these changes
Jan 12, 2017
Member
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
I guess this makes more sense.
|
Why not just use an optional?
…On Wed, Jan 11, 2017 at 7:17 PM Jonathan Leitschuh ***@***.***> wrote:
***@***.**** approved this pull request.
I guess this makes more sense.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#782 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAORVzIFNWzn4qTLGdEWC2qkgf7bhyo4ks5rRXEzgaJpZM4LgP6m>
.
|
Member
Author
|
-1 is a standard result if the object isn't present. See the documentation for |
|
That's only because the list interface was created before Optionals were a
thing.... Stream#findFirst returns an Optional, for example.
…On Wed, Jan 11, 2017 at 7:26 PM Sam Carlberg ***@***.***> wrote:
Merged #782 <#782>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#782 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAORV9Qen_zKfLVS3yoz2LO44Jp2iDkaks5rRXM4gaJpZM4LgP6m>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of throwing an exception. Threading stuff kills it.
Fixes #781