Dynamically resize image previews to fit the pane#711
Merged
SamCarlberg merged 3 commits intoWPIRoboticsProjects:masterfrom Dec 20, 2016
Merged
Dynamically resize image previews to fit the pane#711SamCarlberg merged 3 commits intoWPIRoboticsProjects:masterfrom
SamCarlberg merged 3 commits intoWPIRoboticsProjects:masterfrom
Conversation
Current coverage is 53.16% (diff: 31.48%)@@ master #711 diff @@
==========================================
Files 232 233 +1
Lines 7408 7413 +5
Methods 0 0
Messages 0 0
Branches 722 716 -6
==========================================
+ Hits 3940 3941 +1
- Misses 3296 3298 +2
- Partials 172 174 +2
|
SamCarlberg
force-pushed
the
feat/resize-previews
branch
from
e206fbd to
b6f79ba
Compare
AustinShalit
requested changes
Dec 14, 2016
Member
There was a problem hiding this comment.
Upon deleting a step GRIP crashes.
An event subscriber threw an exception
Stack Trace:
java.util.NoSuchElementException: Step edu.wpi.grip.core.Step@24017b29 is not in the pipeline
at edu.wpi.grip.core.Pipeline.lambda$indexOf$12(Pipeline.java:371)
at edu.wpi.grip.core.Pipeline.accessSafely(Pipeline.java:83)
at edu.wpi.grip.core.Pipeline.readStepsSafely(Pipeline.java:124)
at edu.wpi.grip.core.Pipeline.indexOf(Pipeline.java:368)
at edu.wpi.grip.core.StepIndexer.compare(StepIndexer.java:26)
at edu.wpi.grip.ui.analysis.AnalysisController.lambda$sortedStream$9(AnalysisController.java:211)
at java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
at java.util.TimSort.sort(TimSort.java:220)
at java.util.Arrays.parallelSort(Arrays.java:1113)
at java.util.stream.SortedOps$OfRef.opEvaluateParallel(SortedOps.java:158)
at java.util.stream.AbstractPipeline.opEvaluateParallelLazy(AbstractPipeline.java:704)
at java.util.stream.AbstractPipeline.sourceSpliterator(AbstractPipeline.java:431)
at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
at java.util.stream.DoublePipeline.toArray(DoublePipeline.java:506)
at edu.wpi.grip.ui.analysis.AnalysisController.onPipelineFinish(AnalysisController.java:158)
at sun.reflect.GeneratedMethodAccessor47.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.google.common.eventbus.Subscriber.invokeSubscriberMethod(Subscriber.java:95)
at com.google.common.eventbus.Subscriber$SynchronizedSubscriber.invokeSubscriberMethod(Subscriber.java:154)
at com.google.common.eventbus.Subscriber$1.run(Subscriber.java:80)
at com.google.common.util.concurrent.MoreExecutors$DirectExecutor.execute(MoreExecutors.java:456)
at com.google.common.eventbus.Subscriber.dispatchEvent(Subscriber.java:76)
at com.google.common.eventbus.Dispatcher$PerThreadQueuedDispatcher.dispatch(Dispatcher.java:119)
at com.google.common.eventbus.EventBus.post(EventBus.java:215)
at edu.wpi.grip.core.PipelineRunner$1.runOneIteration(PipelineRunner.java:93)
at com.google.common.util.concurrent.AbstractScheduledService$ServiceDelegate$Task.run(AbstractScheduledService.java:189)
at com.google.common.util.concurrent.Callables$3.run(Callables.java:100)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)System Info:
| Property Name | Property |
|---|---|
| GRIP Version | 1.5.0-rc3-9-gb6f79ba9f |
| java.version | 1.8.0_102 |
| javafx.version | 8.0.102 |
| os.name | Mac OS X |
| os.version | 10.12.2 |
| os.arch | x86_64 |
Member
Author
|
Merging master should fix that. This branch is pretty out-of-date. |
AustinShalit
approved these changes
Dec 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #706 and #710
Example