Skip to content

Comments

Add better support for command line arguments#702

Merged
SamCarlberg merged 4 commits intoWPIRoboticsProjects:masterfrom
SamCarlberg:fix/server-port-taken
Nov 7, 2016
Merged

Add better support for command line arguments#702
SamCarlberg merged 4 commits intoWPIRoboticsProjects:masterfrom
SamCarlberg:fix/server-port-taken

Conversation

@SamCarlberg
Copy link
Member

@SamCarlberg SamCarlberg commented Nov 3, 2016

Set the save file with -f <path> or --file <path>
Set the HTTP server port with -p <port> or --port <port>
Print the version with -v or --version
Print help text with -h or --help
Set headless mode with --headless (UI only)

Can pass command line args through gradle with -Pargs="<args>"

Note: this breaks backwards compatibility with loading files from the command line.

@codecov-io
Copy link

codecov-io commented Nov 3, 2016

Current coverage is 53.67% (diff: 43.68%)

Merging #702 into master will increase coverage by 0.02%

@@             master       #702   diff @@
==========================================
  Files           223        225     +2   
  Lines          7234       7316    +82   
  Methods           0          0          
  Messages          0          0          
  Branches        712        719     +7   
==========================================
+ Hits           3881       3927    +46   
- Misses         3180       3216    +36   
  Partials        173        173          

Sunburst

Powered by Codecov. Last update 8885d0a...d7f9e6b

}
}

// This will thrown an exception if the port specified by the save file is already taken.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"thrown" should be "throw"

Update comment in core main
@SamCarlberg SamCarlberg force-pushed the fix/server-port-taken branch from 51a667d to d7f9e6b Compare November 4, 2016 15:22
@AustinShalit AustinShalit modified the milestone: v1.5.0 Nov 7, 2016
@JLLeitschuh
Copy link
Member

Did you try this in a deployed application?

@SamCarlberg
Copy link
Member Author

If by "deployed" you mean "core app", yes

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@SamCarlberg SamCarlberg merged commit 8db6076 into WPIRoboticsProjects:master Nov 7, 2016
@SamCarlberg SamCarlberg deleted the fix/server-port-taken branch November 7, 2016 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants