Add source for video files by SamCarlberg · Pull Request #698 · WPIRoboticsProjects/GRIP

SamCarlberg · 2016-11-01T21:49:13Z

Currently supports:

mp4
mpeg
avi

Currently only supports .mp4

codecov-io · 2016-11-01T23:05:50Z

Codecov Report

Merging #698 into master will decrease coverage by 1.01%.
The diff coverage is 19.91%.

@@             Coverage Diff              @@
##             master     #698      +/-   ##
============================================
- Coverage     52.45%   51.43%   -1.02%     
- Complexity        0     1146    +1146     
============================================
  Files           240      247       +7     
  Lines          7708     7955     +247     
  Branches        522      539      +17     
============================================
+ Hits           4043     4092      +49     
- Misses         3480     3678     +198     
  Partials        185      185

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3fa6c...bc0b475. Read the comment docs.

JLLeitschuh · 2016-11-22T05:31:05Z

core/src/main/java/edu/wpi/grip/core/sources/VideoFileSource.java

+          eventBus.post(new SourceHasPendingUpdateEvent(VideoFileSource.this));
+          Thread.sleep((long) (1e3 / fps));
+        } catch (InterruptedException | FrameGrabber.Exception e) {
+          getExceptionWitness().flagException(e);


Handle the InterruptedException like an InterruptedException should be handled.
http://www.yegor256.com/2015/10/20/interrupted-exception.html

vampjaz · 2017-01-08T04:54:28Z

I don't know if/when this will get merged but I'm very interested in using video files for testing pipelines instead of static images.

JLLeitschuh · 2017-02-01T01:29:40Z

core/src/main/java/edu/wpi/grip/core/sources/VideoFileSource.java

+          getExceptionWitness().flagException(e);
+        } catch (InterruptedException e) {
+          Thread.currentThread().interrupt();
+          getExceptionWitness().flagException(e, "Interrupted while waiting for next frame");


You probably don't want to flag and you probably want to exit the while loop.

JLLeitschuh · 2017-02-01T01:32:50Z

core/src/main/java/edu/wpi/grip/core/sources/VideoFileSource.java

+ * A source for a video file input.
+ */
+@XStreamAlias("grip:VideoFile")
+public class VideoFileSource extends Source {


There seems to be duplicate code between this and the Camera source. Can any of that be refactored into a base class?

Also, I notice you are using a thread. We had issues with threads and their weirdness. Any reason you didn't implement this as a restarting service?

There are some fundamental differences between them. Camera frame grabbers don't get null frame mats from the conversion; video files do. The grabber for the video file needs to update at a specific rate specified by the file itself; camera sources just grab as fast as possible.

And I'm using a Thread (scheduled executor now) to grab the frames because of these two issues.

Should keep the FPS steady. Also allows it to be paused by external controls if they get added.

JLLeitschuh · 2017-03-09T16:32:13Z

Can you rewind or perhaps restart the video?
What about advancing one frame at a time? Would either of these features be useful?

nightpool · 2017-03-11T16:37:36Z

@JLLeitschuh scope creep

…

On Thu, Mar 9, 2017 at 11:32 AM Jonathan Leitschuh ***@***.***> wrote: Can you rewind or perhaps restart the video? What about advancing one frame at a time? Would either of these features be useful? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#698 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAORVwePp1vlb9LFCpTUMxFZsOjrsX_Xks5rkCmNgaJpZM4Kmn4n> .

SamCarlberg · 2017-03-11T22:38:50Z

That is something that would be worthwhile to include. It would act similar to the multi-image file source, but with a scrubber and play/pause button as well.

Also adds a basic observable framework because JavaFX's observables aren't available to the core module.

SamCarlberg · 2017-03-13T22:58:14Z

There's something weird with the FFMpegFrameGrabber where it'll segfault, seemingly at random. Seems to only happen when scrubbing through a long video?

.mpeg files don't seem to work very well, either. Scrubbing is laggy and I keep getting errors in the console like

[mpegts @ 0x7fce787cda00] Invalid timestamps stream=0, pts=333257999, dts=333261000, size=221

I only have a ~7MB mpeg file though, maybe a smaller one would work better.

Edit: the size doesn't seem to matter, I can use a 20MB mpeg just fine. Might just be a corrupt or poorly encoded file that's causing the problems.

JLLeitschuh · 2017-03-16T15:15:13Z

Seems like you are re-inventing the wheel here:
https://github.com/ReactiveX/RxJava

This library also provides synchronization guarantees.

SamCarlberg · 2017-03-16T15:43:20Z

I wanted to keep it similar to JavaFX's Observables

JLLeitschuh · 2017-03-16T17:58:12Z

Do you want to provide any synchronization guarantees about adding/removing observers?

SamCarlberg · 2017-03-16T18:02:05Z

There are in SynchronizedObservable. Adding or removing an observer will block until all the observers are notified when the value changes.

JLLeitschuh · 2017-03-20T21:16:18Z

Are you sure you don't want to just use RX java's observable?

JLLeitschuh

This looks good. Merge away.

Add source for video files

09ed065

Currently only supports .mp4

JLLeitschuh reviewed Nov 22, 2016

View reviewed changes

SamCarlberg added 3 commits January 30, 2017 18:20

Merge branch 'master' into feat/video-file-source

ebbf044

Wow that's a lot of formats

f92bde9

Handle InterruptedException properly

b10de7c

SamCarlberg requested a review from JLLeitschuh January 31, 2017 22:49

JLLeitschuh reviewed Feb 1, 2017

View reviewed changes

Make VideoFileSource use a ScheduledExeuctor for grabbing frames

4abe7d3

Should keep the FPS steady. Also allows it to be paused by external controls if they get added.

Add play/pause button and scrubber to VideoFileSource

bc0b475

Also adds a basic observable framework because JavaFX's observables aren't available to the core module.

JLLeitschuh approved these changes May 9, 2017

View reviewed changes

SamCarlberg merged commit 182363c into WPIRoboticsProjects:master May 9, 2017

SamCarlberg deleted the feat/video-file-source branch January 28, 2019 20:43

Comments

Conversation

SamCarlberg commented Nov 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Nov 1, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JLLeitschuh Nov 22, 2016

Choose a reason for hiding this comment

Uh oh!

vampjaz commented Jan 8, 2017

Uh oh!

JLLeitschuh Feb 1, 2017

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh Feb 1, 2017

Choose a reason for hiding this comment

Uh oh!

SamCarlberg Feb 2, 2017

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh commented Mar 9, 2017

Uh oh!

nightpool commented Mar 11, 2017 via email

Uh oh!

SamCarlberg commented Mar 11, 2017

Uh oh!

SamCarlberg commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JLLeitschuh commented Mar 16, 2017

Uh oh!

SamCarlberg commented Mar 16, 2017

Uh oh!

JLLeitschuh commented Mar 16, 2017

Uh oh!

SamCarlberg commented Mar 16, 2017

Uh oh!

JLLeitschuh commented Mar 20, 2017

Uh oh!

JLLeitschuh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SamCarlberg commented Nov 1, 2016 •

edited

Loading

codecov-io commented Nov 1, 2016 •

edited

Loading

SamCarlberg commented Mar 13, 2017 •

edited

Loading