Fix a potential deadlock on opening a project#691
Merged
SamCarlberg merged 2 commits intoWPIRoboticsProjects:masterfrom Oct 25, 2016
Merged
Fix a potential deadlock on opening a project#691SamCarlberg merged 2 commits intoWPIRoboticsProjects:masterfrom
SamCarlberg merged 2 commits intoWPIRoboticsProjects:masterfrom
Conversation
Current coverage is 54.56% (diff: 100%)@@ master #691 diff @@
==========================================
Files 209 209
Lines 6713 6715 +2
Methods 0 0
Messages 0 0
Branches 656 656
==========================================
+ Hits 3657 3664 +7
+ Misses 2886 2884 -2
+ Partials 170 167 -3
|
JLLeitschuh
approved these changes
Oct 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deadlock is caused by
SocketImpl.setValueOptionalbeing a synchronized method and posting a SocketChangedEvent that the UI thread tries to handle by locking on the socket when getting it's value.