Solves deadlocking when opening a saved project#685
Merged
SamCarlberg merged 2 commits intoWPIRoboticsProjects:masterfrom Oct 12, 2016
Merged
Solves deadlocking when opening a saved project#685SamCarlberg merged 2 commits intoWPIRoboticsProjects:masterfrom
SamCarlberg merged 2 commits intoWPIRoboticsProjects:masterfrom
Conversation
Fixes a deadlock when loading a project in the middle of an output image being rendered
JLLeitschuh
approved these changes
Oct 12, 2016
Member
JLLeitschuh
left a comment
JLLeitschuh
left a comment
There was a problem hiding this comment.
This looks good. I don't think we have any tests for this unfortunately.
Member
|
Fails checkstyle on windows. |
Current coverage is 54.50% (diff: 0.00%)@@ master #685 diff @@
==========================================
Files 209 209
Lines 6706 6713 +7
Methods 0 0
Messages 0 0
Branches 656 656
==========================================
Hits 3659 3659
- Misses 2878 2886 +8
+ Partials 169 168 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a deadlock when loading a project while an output image is being rendered