Skip to content

Comments

Solve ordering issue when opening a file via command line#671

Merged
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
AustinShalit:fix/fileFromParameter
Sep 7, 2016
Merged

Solve ordering issue when opening a file via command line#671
JLLeitschuh merged 1 commit intoWPIRoboticsProjects:masterfrom
AustinShalit:fix/fileFromParameter

Conversation

@AustinShalit
Copy link
Member

closes #670

@codecov-io
Copy link

codecov-io commented Sep 7, 2016

Current coverage is 58.48% (diff: 0.00%)

Merging #671 into master will not change coverage

@@             master       #671   diff @@
==========================================
  Files           198        198          
  Lines          6282       6282          
  Methods           0          0          
  Messages          0          0          
  Branches        569        569          
==========================================
  Hits           3674       3674          
- Misses         2439       2440     +1   
+ Partials        169        168     -1   

Sunburst

Powered by Codecov. Last update a9659d0...3d9f76a

@JLLeitschuh
Copy link
Member

You tested this? If yes then LGTM!

@AustinShalit
Copy link
Member Author

Yup. Tested and it is good.

@JLLeitschuh
Copy link
Member

LGTM!

@AustinShalit
Copy link
Member Author

pullapprove is broken

@JLLeitschuh
Copy link
Member

I'm chatting with someone there right now.

@JLLeitschuh JLLeitschuh merged commit f9c17eb into WPIRoboticsProjects:master Sep 7, 2016
@AustinShalit AustinShalit deleted the fix/fileFromParameter branch September 7, 2016 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I can No longer auto launch the Grip app and load a pipeline

3 participants