Osulacam minimize steps by AustinShalit · Pull Request #659 · WPIRoboticsProjects/GRIP

AustinShalit · 2016-08-09T19:06:11Z

closes #327
closes #639

Fix-up of #639

…y hides the sockets with a view.

…into MinimizeSteps

This should give me a better idea of why it is failing on Travis and AppVeyor.

…ation on why it fails on Travis and AppVeyor.

… osulacam-MinimizeSteps

JLLeitschuh · 2016-08-09T19:20:15Z

ui/src/main/java/edu/wpi/grip/ui/pipeline/StepController.java


+    if (step.getInputSockets().stream()
+        .allMatch(inputSocket -> inputSocket.getSocketHint().getView()
+            .equals(SocketHint.View.NONE))) {


I don't think this logic holds true. Does it?

This is saying if there is no user interaction in this step do not show the arrow

For example:
Desaturate does not allow for user interaction - no arrow is shown. Filter Contours does -- the arrow is shown.

codecov-io · 2016-08-09T19:25:11Z

Current coverage is 58.03% (diff: 85.93%)

Merging #659 into master will increase coverage by 0.39%

@@             master       #659   diff @@
==========================================
  Files           195        196     +1   
  Lines          6101       6165    +64   
  Methods           0          0          
  Messages          0          0          
  Branches        554        561     +7   
==========================================
+ Hits           3517       3578    +61   
- Misses         2420       2424     +4   
+ Partials        164        163     -1

Powered by Codecov. Last update 1e5fcd4...59f59f8

AustinShalit · 2016-08-09T22:17:04Z

I added the ability to double click the arrow. On a double click it will toggle all steps.

SamCarlberg · 2016-08-09T22:30:14Z

ui/src/main/java/edu/wpi/grip/ui/events/SetStepsExpandedEvent.java

@@ -0,0 +1,14 @@
+package edu.wpi.grip.ui.events;
+
+public class SetStepsExpandedEvent {


Documentation

JLLeitschuh · 2016-08-10T01:05:15Z

ui/src/main/java/edu/wpi/grip/ui/pipeline/StepController.java

                 OutputSocketController.Factory outputSocketControllerFactory,
                 ExceptionWitnessResponderButton.Factory exceptionWitnessResponderButtonFactory,
                 StepDragService stepDragService,
+                 @Assisted EventBus eventBus,


Why is this assisted? This doesn't need to be assisted.

Spaghetti code

JLLeitschuh · 2016-08-10T01:19:23Z

ui/src/main/java/edu/wpi/grip/ui/pipeline/StepController.java

+  @Subscribe
+  public void setExpanded(SetStepsExpandedEvent event) {
+    expanded.set(event.isExpanded());
+  }


Strange way that this is written. But sure.
Maybe document that a double click will expand all.

Why do you think it is strange?

How would you write it?

JLLeitschuh · 2016-08-11T02:46:11Z

LGTM!

![Approved with PullApprove](https://img.shields.io/badge/GRIP Merge Approvers-approved-brightgreen.svg)

osulacam and others added 18 commits July 25, 2016 14:26

New expand and contract options for all steps.

6bf7f32

Checkstyle fixes because I forgot.

5fe965d

fixed buttons.

765e402

Moves button to the top

7e9854c

Only shows the button on the operations that need it and minimize onl…

669c732

…y hides the sockets with a view.

Checkstyle fixes

c9e632f

Merge branch 'master' of https://github.com/WPIRoboticsProjects/GRIP …

b488311

…into MinimizeSteps

Added a test for the button.

a46cd55

No longer switches the order of sockets.

cc0cbb8

Testing is working on my computer.

e7a9e15

This should give me a better idea of why it is failing on Travis and AppVeyor.

checkstyle fix

44585dd

Testing still works on my computer. Just commiting to get more inform…

2fbf3ff

…ation on why it fails on Travis and AppVeyor.

Test should be fixed

f7018cf

Added an animation.

47e3279

Fixed the jumpy bug and made the animation slightly faster.

4a5fabb

Fixed bug with animation hiding connected sockets.

3409330

Merge branch 'MinimizeSteps' of https://github.com/osulacam/GRIP into…

9b53dc3

… osulacam-MinimizeSteps

Cache images

9f80373

AustinShalit added the ready for review label Aug 9, 2016

AustinShalit added this to the v1.5.0 milestone Aug 9, 2016

AustinShalit changed the title ~~Osulacam minimize steps (#639)~~ Osulacam minimize steps Aug 9, 2016

JLLeitschuh reviewed Aug 9, 2016
View reviewed changes

AustinShalit added in progress and removed ready for review labels Aug 9, 2016

Use lambdas & cleanup

323412d

AustinShalit added ready for review in progress and removed in progress ready for review labels Aug 9, 2016

AustinShalit added ready for review and removed in progress labels Aug 9, 2016

AustinShalit force-pushed the osulacam-MinimizeSteps branch from c8857b6 to eb1b013 Compare August 9, 2016 22:20

SamCarlberg reviewed Aug 9, 2016
View reviewed changes

AustinShalit force-pushed the osulacam-MinimizeSteps branch from eb1b013 to 8ebaf29 Compare August 9, 2016 22:38

AustinShalit added type: feature location: ui labels Aug 9, 2016

JLLeitschuh reviewed Aug 10, 2016
View reviewed changes

AustinShalit force-pushed the osulacam-MinimizeSteps branch 2 times, most recently from b1cad27 to a93b0fb Compare August 10, 2016 01:09

JLLeitschuh reviewed Aug 10, 2016
View reviewed changes

Double click

5b1e389

AustinShalit force-pushed the osulacam-MinimizeSteps branch from a93b0fb to 5b1e389 Compare August 10, 2016 16:36

Left click

59f59f8

AustinShalit merged commit bbea07c into WPIRoboticsProjects:master Aug 11, 2016

AustinShalit deleted the osulacam-MinimizeSteps branch August 11, 2016 03:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Osulacam minimize steps#659

Osulacam minimize steps#659
AustinShalit merged 21 commits intoWPIRoboticsProjects:masterfrom
AustinShalit:osulacam-MinimizeSteps

AustinShalit commented Aug 9, 2016 •

edited

Loading

Uh oh!

JLLeitschuh Aug 9, 2016

Uh oh!

AustinShalit Aug 9, 2016

Uh oh!

AustinShalit Aug 9, 2016

Uh oh!

codecov-io commented Aug 9, 2016 •

edited

Loading

Uh oh!

AustinShalit commented Aug 9, 2016

Uh oh!

SamCarlberg Aug 9, 2016

Uh oh!

JLLeitschuh Aug 10, 2016

Uh oh!

AustinShalit Aug 10, 2016

Uh oh!

JLLeitschuh Aug 10, 2016

Uh oh!

AustinShalit Aug 10, 2016

Uh oh!

AustinShalit Aug 10, 2016

Uh oh!

JLLeitschuh commented Aug 11, 2016 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -0,0 +1,14 @@
		package edu.wpi.grip.ui.events;

		public class SetStepsExpandedEvent {

Comments

Conversation

AustinShalit commented Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Aug 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 58.03% (diff: 85.93%)

Uh oh!

AustinShalit commented Aug 9, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh commented Aug 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AustinShalit commented Aug 9, 2016 •

edited

Loading

codecov-io commented Aug 9, 2016 •

edited

Loading

JLLeitschuh commented Aug 11, 2016 •

edited

Loading