Add Checkstyle NewlineAtEndOfFile#656
Add Checkstyle NewlineAtEndOfFile#656AustinShalit merged 1 commit intoWPIRoboticsProjects:masterfrom
Conversation
|
I had planned on getting this in the original checkstyle PR but it didn't work well with cross-platform stuff (code written on OS X would fail checkstyle on Windows because newlines on Unix and carriage returns on Windows) |
|
Appveyor is failing. |
|
Yea... I am just testing to see if I can get this to work. |
AustinShalit
force-pushed
the
fix/NewlineAtEndOfFile
branch
from
289443c to
d52e68e
Compare
Current coverage is 57.67% (diff: 100%)@@ master #656 diff @@
==========================================
Files 195 195
Lines 6091 6091
Methods 0 0
Messages 0 0
Branches 554 554
==========================================
Hits 3513 3513
+ Misses 2415 2414 -1
- Partials 163 164 +1
|
AustinShalit
force-pushed
the
fix/NewlineAtEndOfFile
branch
from
d52e68e to
ab2a8f8
Compare
AustinShalit
added
Developer Discussion/Decision
ready for review
and removed
Developer Discussion/Decision
in progress
labels
|
Fixed. Now it checks for the unix line separator at the end of files. |
|
|
||
| <!--<module name="NewlineAtEndOfFile" />--> <!-- Screwed up on Appveyor for some reason --> | ||
| <module name="NewlineAtEndOfFile"> | ||
| <property name="lineSeparator" value="lf"/> |
There was a problem hiding this comment.
This can be changed to allow windows line separators also. Thoughts?
There was a problem hiding this comment.
I don't know. I don't understand the whole Windows line ending thing vs linux. Someone else is going to have to explain/approve this change.
@bradamiller You understand this?
There was a problem hiding this comment.
There was a problem hiding this comment.
I think only supporting the linux line feed makes sense.
4 participants
No description provided.