Skip to content

Comments

Minimize/Maximize options for all steps.#639

Closed
osulacam wants to merge 16 commits intoWPIRoboticsProjects:masterfrom
osulacam:MinimizeSteps
Closed

Minimize/Maximize options for all steps.#639
osulacam wants to merge 16 commits intoWPIRoboticsProjects:masterfrom
osulacam:MinimizeSteps

Conversation

@osulacam
Copy link
Contributor

Implements the suggestion in #327

@SamCarlberg
Copy link
Member

Screenshots / gif / video?

@AustinShalit
Copy link
Member

AustinShalit commented Jul 25, 2016

Step left/right buttons are broken. I think the button should be at the top of the step and never move vertically.

@osulacam
Copy link
Contributor Author

screen shot 2016-07-25 at 2 54 44 pm

screen shot 2016-07-25 at 2 54 17 pm

I'll try putting it on top and see if it helps.

}

.expand {
-fx-background-color: transparent;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line contains a tab.

@SamCarlberg
Copy link
Member

SamCarlberg commented Jul 25, 2016

The Mask step shouldn't have the expand/contract arrow because it doesn't actually do anything. I think you should only have it for steps that have user controls (sliders, checkboxes, etc).

Something like

if (step.getOperation().getInputSockets().stream()
    .map(Socket::getView)
    .anyMatch(view -> !view.equals(View.NONE)) {
  // This step takes user input, add the collapse/expand arrow
}

@codecov-io
Copy link

codecov-io commented Jul 25, 2016

Current coverage is 58.17% (diff: 98.30%)

Merging #639 into master will decrease coverage by 0.77%

@@             master       #639   diff @@
==========================================
  Files           194        194          
  Lines          6051       6118    +67   
  Methods           0          0          
  Messages          0          0          
  Branches        550        558     +8   
==========================================
- Hits           3567       3559     -8   
- Misses         2323       2394    +71   
- Partials        161        165     +4   

Sunburst

Powered by Codecov. Last update 28d7e0b...3409330

@osulacam
Copy link
Contributor Author

I'm pretty happy with this. Let me know if you think anything can be improved.

screen shot 2016-07-25 at 5 01 02 pm

screen shot 2016-07-25 at 5 01 22 pm

@AustinShalit
Copy link
Member

@AustinShalit
Copy link
Member

This might be beyond the bonds of this pr but an animation would be a cool thing to add to this.

@osulacam
Copy link
Contributor Author

I agree that it would be cool but it's probably better to just get this working and add the animation later in a different pull request.

@SamCarlberg
Copy link
Member

See: http://stackoverflow.com/questions/13990664/how-to-make-a-vbox-with-animated-close-up

Should be able to call input.getRoot().setVisible(false) for each unconnected input, then collapse the pane containing the inputs

@SamCarlberg
Copy link
Member

The animations are really nice! But I've found some problems with it

@AustinShalit AustinShalit modified the milestone: v2.0.0 Jul 29, 2016
.equals(SocketHint.View.NONE))) {
expand.setManaged(false);
} else {
expandIcon.setImage(new Image("/edu/wpi/grip/ui/icons/up.png"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cache the image in the object so it isn't loaded from disk every time you click the button?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants