Add a loading screen by AustinShalit · Pull Request #629 · WPIRoboticsProjects/GRIP

AustinShalit · 2016-07-18T22:26:25Z

I added a loading screen to GRIP.

@JLLeitschuh Something that will make this nicer is a higher quality version of the GRIP logo.

Video Demo: https://youtu.be/J08DqqBTGPY

codecov-io · 2016-07-18T22:34:20Z

Current coverage is 57.73% (diff: 0.00%)

Merging #629 into master will decrease coverage by 1.12%

@@             master       #629   diff @@
==========================================
  Files           194        194          
  Lines          6051       6062    +11   
  Methods           0          0          
  Messages          0          0          
  Branches        550        551     +1   
==========================================
- Hits           3562       3500    -62   
- Misses         2327       2398    +71   
- Partials        162        164     +2

Powered by Codecov. Last update 4a4b71c...307cb09

SamCarlberg · 2016-07-19T00:49:41Z

ui/src/main/java/edu/wpi/grip/ui/GripPreloader.java

+  private Stage preloaderStage;
+
+  @Override
+  public void start(Stage preloaderStage) throws Exception {


I'm assuming this is part of the method signature defined by Preloader.start?

You don't have to throw the Exception even if the parent class does. I'd rather see explicitly what methods this method actually throws.
Try removing it and adding only the exceptions that get thrown and see if it still compiles. I bet it will.

JLLeitschuh · 2016-07-19T04:07:27Z

I like it!

JLLeitschuh · 2016-07-19T04:16:51Z

ui/src/main/java/edu/wpi/grip/ui/Main.java

 import com.google.inject.Guice;
 import com.google.inject.Injector;
 import com.google.inject.util.Modules;
+import com.sun.javafx.application.LauncherImpl;


You're supposed to avoid this package. Is there another way to do this?? If not it's fine.

I found another way. Thanks!

@JLLeitschuh Just for future reference, com.sun.* is fine, it's sun.* that should be avoided

AustinShalit · 2016-07-19T04:17:01Z

Has anyone have experience with loading bars? How do you decide when to add to the completion of the bar?

JLLeitschuh · 2016-07-19T04:18:02Z

You'll have to ask @ThomasJClark for a higher quality version of the GRIP logo.
I'll see if I can get one out of him.

AustinShalit · 2016-07-19T04:20:14Z

If possible a vector drawing.

AustinShalit · 2016-07-19T07:11:28Z

ui/src/main/java/edu/wpi/grip/ui/Main.java

+    notifyPreloader(new Preloader.ProgressNotification(0.45));
    server.addHandler(pipelineSwitcher);
    server.start();
+    notifyPreloader(new Preloader.ProgressNotification(0.6));


Comments on the location of these progress events? Should I add more or have less...

JLLeitschuh · 2016-07-19T12:22:59Z

https://drive.google.com/file/d/0BxB84d-nlZLcc1V0akVlZ0dPSW8/view

SamCarlberg · 2016-07-19T18:22:49Z

ui/preloader/src/main/java/edu/wpi/grip/preloader/GripPreloader.java

    progressBar = (ProgressBar) root.getChildrenUnmodifiable().filtered(
        p -> p instanceof ProgressBar).get(0);

+    System.setProperty("prism.lcdtext", "false");


What does this do?

Font smoothing

JLLeitschuh · 2016-07-20T05:11:18Z

How does this look on High DPI screens? Any idea?

AustinShalit · 2016-07-20T05:18:26Z

My guess would be that the loading bar would look taller than it does on a normal display. The image is locked at display width / 4.

Edit: Take a look at this https://youtu.be/VwDD86o8PCQ

JLLeitschuh · 2016-07-20T14:36:11Z

Cool! Looks awesome!

JLLeitschuh · 2016-07-20T14:43:31Z

ui/src/main/java/edu/wpi/grip/ui/Main.java

          new GripSourcesHardwareModule()).with(new GripNetworkModule(), new GripUiModule()));
-
      injector.injectMembers(this);
+      notifyPreloader(new Preloader.ProgressNotification(0.15));


I can guarantee you that creating the dependency injector probably takes the most amount of time.

Right now the longest thing for me is starting the Jetty server

SamCarlberg · 2016-07-20T14:43:42Z

The loading bar color doesn't fit the theme. Can you change it to more of a forest green that matches the lighter green in the logo?

JLLeitschuh · 2016-07-20T15:13:36Z

ui/preloader/src/main/java/edu/wpi/grip/preloader/GripPreloader.java

+  public void handleApplicationNotification(PreloaderNotification pn) {
+    if (pn instanceof ProgressNotification) {
+      progressBar.setProgress(((ProgressNotification) pn).getProgress());
+    } else if (pn instanceof StateChangeNotification


Instance of!!! Bah! But this is probably the only way.
So, fine, this works.

I agree... they should change the api

AustinShalit · 2016-07-20T15:26:15Z

@SamCarlberg For the color are you thinking something like A4CFBE or 58a787?

SamCarlberg · 2016-07-20T15:32:58Z

I think something more like 33cc33. Those look too desaturated imo

AustinShalit · 2016-07-20T16:02:42Z

After discussion on gitter - 6C8058 was picked

SamCarlberg · 2016-07-21T01:01:23Z

Getting this at the end of the stacktrace when I quit the app (it runs fine, though)

:ui:preloader:run FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ui:preloader:run'.
> No main class specified

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 43.931 secs
No main class specified
8:55:59 PM: External tasks execution finished 'clean run'.

Edit: only when running from intellij, it's fine when run from the command line.

SamCarlberg · 2016-07-21T01:05:48Z

The text is pretty jaggy for me (OS X Yosemite)

AustinShalit · 2016-07-21T05:36:43Z

@SamCarlberg I fixed the issue with your first comment. You can run the task :ui:preloader:run to test the Preloader. Can you run it in test mode and see if the text is still jaggy?

JLLeitschuh · 2016-07-21T18:38:52Z

Is this good to go?

AustinShalit · 2016-07-21T18:40:54Z

Waiting on a response from @SamCarlberg

AustinShalit · 2016-07-24T02:08:48Z

@SamCarlberg bump

SamCarlberg · 2016-07-25T19:09:25Z

AustinShalit · 2016-07-25T21:52:16Z

@SamCarlberg The latest commit should fix the issue

JLLeitschuh · 2016-07-26T02:38:22Z

Good yet?

AustinShalit · 2016-07-26T04:22:05Z

I think so. @SamCarlberg should probably test it again first

SamCarlberg · 2016-07-26T13:44:44Z

Scaling issue is fixed.

AustinShalit · 2016-07-26T15:27:20Z

LGTM

AustinShalit force-pushed the loading-screen branch from 120d4de to 91d7f9a Compare July 18, 2016 22:45

SamCarlberg reviewed Jul 19, 2016
View reviewed changes

AustinShalit force-pushed the loading-screen branch from 91d7f9a to dd7eb5b Compare July 19, 2016 04:11

JLLeitschuh reviewed Jul 19, 2016
View reviewed changes

Add a loading screen

2f99d73

AustinShalit force-pushed the loading-screen branch from dd7eb5b to 2f99d73 Compare July 19, 2016 04:48

Preloader in its own jar

3c0ccf0

AustinShalit force-pushed the loading-screen branch from 30a9ae6 to 3c0ccf0 Compare July 19, 2016 06:22

AustinShalit reviewed Jul 19, 2016
View reviewed changes

AustinShalit force-pushed the loading-screen branch 3 times, most recently from dab4552 to 6edca52 Compare July 19, 2016 07:16

ProgressBar displays progress

b524f8e

AustinShalit force-pushed the loading-screen branch from 6edca52 to b524f8e Compare July 19, 2016 07:19

HD Image

9a5b3a1

SamCarlberg reviewed Jul 19, 2016
View reviewed changes

JLLeitschuh reviewed Jul 20, 2016
View reviewed changes

Update Progress Bar color

094b893

AustinShalit added the ready for review label Jul 20, 2016

Add the ability to test the preloader

b69e509

Fix scaling

307cb09

JLLeitschuh merged commit c05adc1 into WPIRoboticsProjects:master Jul 26, 2016

AustinShalit deleted the loading-screen branch July 26, 2016 20:28

AustinShalit added this to the v2.0.0 milestone Jul 29, 2016

AustinShalit mentioned this pull request Sep 6, 2016

I can No longer auto launch the Grip app and load a pipeline #670

Closed

Comments

Conversation

AustinShalit commented Jul 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Jul 18, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 57.73% (diff: 0.00%)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh commented Jul 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AustinShalit commented Jul 19, 2016

Uh oh!

JLLeitschuh commented Jul 19, 2016

Uh oh!

AustinShalit commented Jul 19, 2016

Uh oh!

AustinShalit Jul 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh commented Jul 19, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLLeitschuh commented Jul 20, 2016

Uh oh!

AustinShalit commented Jul 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JLLeitschuh commented Jul 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SamCarlberg commented Jul 20, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AustinShalit commented Jul 20, 2016

Uh oh!

SamCarlberg commented Jul 20, 2016

Uh oh!

AustinShalit commented Jul 20, 2016

Uh oh!

SamCarlberg commented Jul 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SamCarlberg commented Jul 21, 2016

Uh oh!

AustinShalit commented Jul 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JLLeitschuh commented Jul 21, 2016

Uh oh!

AustinShalit commented Jul 21, 2016

Uh oh!

AustinShalit commented Jul 24, 2016

Uh oh!

SamCarlberg commented Jul 25, 2016

Uh oh!

AustinShalit commented Jul 25, 2016

Uh oh!

AustinShalit commented Jul 18, 2016 •

edited

Loading

codecov-io commented Jul 18, 2016 •

edited

Loading

AustinShalit Jul 19, 2016 •

edited

Loading

AustinShalit commented Jul 20, 2016 •

edited

Loading

SamCarlberg commented Jul 21, 2016 •

edited

Loading

AustinShalit commented Jul 21, 2016 •

edited

Loading