Add About window#588
Conversation
|
That looks awesome! Do you want to add a link to the github site somewhere? |
|
I added a button to bring the user to the github page. The only possible issue is that I had to make Main a singleton. Let me know what you think...
|
|
|
||
| public class Main extends Application { | ||
|
|
||
| private static Main instance; |
There was a problem hiding this comment.
Can you like, not do this.... Hahahahah
No static state please. This is why we have dependency injection.
|
Currently broken. I have little (read: no) experience with dependency injection. @JLLeitschuh Do you know why it is not working as written? |
|
I'll take a look tomorrow |
|
Looks weird now. |
|
Buttons shouldn't have ellipses in the text, remove them. |
|
New Style. Default: |
|
Some issues I've found (running Windows 8.1, not sure if it's present on OS X or Linux)
|
|
I updated the style again. This should fix the weird rectangle issue. Still not sure why the font is/was being weird. |
AustinShalit
force-pushed
the
AboutWindow
branch
3 times, most recently
from
accacb3 to
2e0ab16
Compare
|
Mac: |
AustinShalit
force-pushed
the
AboutWindow
branch
3 times, most recently
from
693422b to
ed55d84
Compare
|
Updated to solve the failing tests. |
| </HBox> | ||
| </children> | ||
| <stylesheets> | ||
| <URL value="@roboto/Roboto.css" /> |
There was a problem hiding this comment.
This line (90) needs to be removed with #590.
|
@SamCarlberg Can you please check the latest to see if smoothing is correct? |
|
|
||
| @FXML | ||
| void initialize() { | ||
| assert versionNumberLabel != null : "fx:id=\"versionNumberText\" was not injected: check your FXML file 'AboutDialog.fxml'."; |
There was a problem hiding this comment.
Not sure if this is necessary.
|
Looks good to me |
|
This is ready to merge |
3 participants
Adds an about window that uses FXML.
Closes #439