This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Ensure post deletion is idempotent #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Practically speaking: a DELETE request to a post resource will ensure the post is trashed. If the post is already trashed, no change will occur. To permanently delete, pass force=true, and it will be permanently deleted regardless of status. This is a change from the previous behaviour of the first DELETE trashing the post, and the second DELETE permanently deleting it.
Member
Author
|
The second commit here also returns a 410 Gone if you call (Also, still needs testing.) |
Member
Author
|
As reflected by the low line-count change, this is a pretty simple fix for the bug. This isn't the full solution to #789, as it's clear we need more than this in any case, but the bug needs to be fixed before we can ship beta 1. |
rachelbaker
added a commit
that referenced
this pull request
Apr 22, 2015
Ensure post deletion is idempotent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Practically speaking: a DELETE request to a post resource will ensure the post is trashed. If the post is already trashed, no change will occur. To permanently delete, pass force=true, and it will be permanently deleted regardless of status.
This is a change from the previous behaviour of the first DELETE trashing the post, and the second DELETE permanently deleting it.
See #789.