Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@osiux
Copy link
Contributor

@osiux osiux commented Feb 18, 2014

Travis-CI builds are returning an error about not being able to clone the repo into the plugins folder, I wasn't able to reproduce it locally (copy & paste every line on the output), so instead of cloning again I just changed it to copy the files. It has the advantage that this way it can also build and test pull requests.

Also changed the git repo for WordPress to the official one: http://make.wordpress.org/core/2014/01/15/git-mirrors-for-wordpress/

@rmccue
Copy link
Member

rmccue commented Feb 18, 2014

@tierra Can you review this please? :)

@osiux
Copy link
Contributor Author

osiux commented Feb 18, 2014

Build still failing on two of the four scenarios defined, but now we can see what the error was: https://travis-ci.org/WP-API/WP-API/builds/19077435 :)

@rmccue
Copy link
Member

rmccue commented Feb 18, 2014

Not too concerned about builds failing on 3.8, see fa5ac57 in #76.

@osiux
Copy link
Contributor Author

osiux commented Feb 18, 2014

Oh, excellent! I like the idea to only test against trunk.

@osiux
Copy link
Contributor Author

osiux commented Feb 18, 2014

Better yet, if we are only testing against trunk, then it would be a good idea to use - - depth=1 (can't remember if it's the right command) when cloning WP so it builds faster.

@rmccue
Copy link
Member

rmccue commented Feb 18, 2014

Better yet, if we are only testing against trunk, then it would be a good idea to use - - depth=1 (can't remember if it's the right command) when cloning WP so it builds faster.

Good idea, and yeah, --depth=1 should give us a shallow clone.

@tierra
Copy link
Contributor

tierra commented Feb 18, 2014

Well, you can just switch out the clone that fails there with a cp -R or rsync as well, this normally works fine (see this build). It didn't need to be a git clone, it's just more efficient to do so in most cases.

@tierra
Copy link
Contributor

tierra commented Feb 18, 2014

Also worth noting that since there's actually official Git repos for core now, I'll push an update to the URLs too.

@rmccue
Copy link
Member

rmccue commented Feb 18, 2014

Cool, I'm going to go ahead and merge this then. :)

rmccue added a commit that referenced this pull request Feb 19, 2014
@rmccue rmccue merged commit 306e700 into WP-API:master Feb 19, 2014
@osiux osiux deleted the fix-travis-integration branch February 19, 2014 11:23
@rmccue rmccue added the Bug label Mar 8, 2014
@rmccue rmccue added this to the 0.9 milestone Mar 8, 2014
@rmccue rmccue added the Testing label Mar 8, 2014
@rmccue rmccue self-assigned this Mar 8, 2014
kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants