-
Notifications
You must be signed in to change notification settings - Fork 651
Check if post status is public in check_read_permission() #787
Conversation
|
@vlood Good catch. Thank you for the patch. This PR needs two things to be merged:
Can you update your PR? |
|
Yep, will do this :) |
|
@vlood Any updates here? :) |
|
Yeah, I've written some tests, but have no PHPUnit setup on my environment and just had my laptop destroyed, so I got other issues to face. I can update the pull request with the tests (and the spacing convention applied), if this is okay with you? |
|
Ouch, sucks to hear that! Any updates you have are fine (even if non-functional); we can fix up any other issues on our end. |
|
Okay, this should be it - c5f618a comes with the tests and stuff :) |
|
The PR is refreshed after the last changes in the file structure that made it's previous commits impossible for automatic merge. Let me know if you need anything else in order to have this one accepted. |
|
Closing in favor of #1765 |
Before this change all posts with custom post statuses were left behind.