Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@vlood
Copy link

@vlood vlood commented Jan 19, 2015

Before this change all posts with custom post statuses were left behind.

@rachelbaker
Copy link
Member

@vlood Good catch. Thank you for the patch. This PR needs two things to be merged:

  1. Spacing adjustments to match the WordPress Coding Standards: https://make.wordpress.org/core/handbook/coding-standards/php/#space-usage
  2. Unit tests to confirm that custom post statuses set to public are allowed.

Can you update your PR?

@rachelbaker rachelbaker added this to the 2.0 milestone Jan 19, 2015
@vlood
Copy link
Author

vlood commented Jan 20, 2015

Yep, will do this :)

@rmccue
Copy link
Member

rmccue commented Feb 11, 2015

@vlood Any updates here? :)

@vlood
Copy link
Author

vlood commented Feb 11, 2015

Yeah, I've written some tests, but have no PHPUnit setup on my environment and just had my laptop destroyed, so I got other issues to face. I can update the pull request with the tests (and the spacing convention applied), if this is okay with you?

@rmccue
Copy link
Member

rmccue commented Feb 11, 2015

Ouch, sucks to hear that!

Any updates you have are fine (even if non-functional); we can fix up any other issues on our end.

@vlood
Copy link
Author

vlood commented Feb 11, 2015

Okay, this should be it - c5f618a comes with the tests and stuff :)

@vlood
Copy link
Author

vlood commented Apr 2, 2015

The PR is refreshed after the last changes in the file structure that made it's previous commits impossible for automatic merge. Let me know if you need anything else in order to have this one accepted.

@danielbachhuber
Copy link
Member

Closing in favor of #1765

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants