Comments Endpoints #693
Comments Endpoints #693
Conversation
Also we send the "Allow" header taking into account the capabilities and the current user
… retreive sent headers
I had to make the send_header() method public on the server class - which I don't think is a bad thing.
…tion is doing my head in!
This means we can get rid of the spy methods too
…'t have to dig for it twice
Conflicts: tests/test-json-server.php
…to pass the context param
| 'number' => isset( $request['per_page'] ) ? (int) $request['per_page'] : 10, | ||
| 'post_id' => isset( $request['post_id'] ) ? (int) $request['post_id'] : 0, | ||
| 'user_id' => isset( $request['user_id'] ) ? (int) $request['user_id'] : '', | ||
| 'status' => isset( $request['status'] ) ? (int) $request['status'] : '', |
There was a problem hiding this comment.
Do we need to normalize the status argument in some way? (e.g. do we want to expose more friendly status arguments)?
Dig it! |
…it was decided we don't want to try to with declerativly.
Conflicts: lib/class-wp-json-server.php tests/test-json-server.php
| protected function check_read_post_permission( $post ) { | ||
| $posts_controller = new WP_JSON_Posts_Controller; | ||
|
|
||
| return $posts_controller->check_read_permission( $post ); |
There was a problem hiding this comment.
Seems too tightly-coupled. Can we do it in a more de-coupled manner?
Do comments always need to have a post? If so, why are we exposing them at /wp/comments ?
There was a problem hiding this comment.
Related Trac Ticket: https://core.trac.wordpress.org/ticket/23931
When checking capabilities some checks return wp_die or fail if there isn't a post_id associated with a post.
|
Thanks @rachelbaker , looking pretty good. Just needs a little bit of cleanup. |
|
|
||
| $prepared_args['offset'] = $prepared_args['number'] * ( absint( $request['page'] ) - 1 ); | ||
|
|
||
| if ( current_user_can( 'edit_posts' ) ) { |
There was a problem hiding this comment.
@rmccue @justinshreve @joehoyle I expanded the available /comments query parameters BUT I limited the parameters available to unauthenticated users. I tried to separate what is "public" vs "private" using some logic. Any concerns here?
There was a problem hiding this comment.
The private vs public separation here makes sense to me.
|
and how to enable this? like this? |
|
+1 how enable guest comments now? |
|
|
Still a Work In Progress, but opening to show progress and encourage any feedback as this progresses.
I took the (controversial) decision to use /comments as the canonical place for comments. I was then thinking
/posts/1/commentswould 301 to/comments?post_id=1or somehting along those lines. I think it's nicer to keep the comments at their own top level so they are independant of posts apart from the embedding we are doing elsewhere already.