-
Notifications
You must be signed in to change notification settings - Fork 651
Initial pass at new style Users Controller #603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should live in the server.
|
Making a note to bring over #608 into this branch. |
lib/class-wp-json-server.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To maximize usefulness, let's build a CSV list of all missing required parameters before finally returning the WP_Error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 3337e4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than creating a one-off method, what if you could register a route to a callback and always specify an argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielbachhuber We surely can. To keep the scope of this PR limited I am trying to just "port" over the current Users routes to the new controller style. Okay to do that in another issue/PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@WP-API/amigos I have finished my initial pass at migrating the user routes over to our new controller style. Please review the PR for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
|
Let's 🚢 🚢 🚢 :) I've broken what I want to discuss into separate issues. @WP-API/amigos feel free to do the same |
Initial pass at new style Users Controller
Initial Controller routes and methods:
Test coverage routes and methods: