This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Register description attribute when registering args from schema#2362
Merged
rachelbaker merged 2 commits intodevelopfrom Mar 13, 2016
Merged
Register description attribute when registering args from schema#2362rachelbaker merged 2 commits intodevelopfrom
description attribute when registering args from schema#2362rachelbaker merged 2 commits intodevelopfrom
Conversation
Member
|
This looks fine to me and it would be nice to have the description for args. Does my review count for merge or should I wait for more official review to merge? |
rachelbaker
added a commit
that referenced
this pull request
Mar 13, 2016
Register `description` attribute when registering args from schema
Member
|
Merged #2362 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.