Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@danielbachhuber
Copy link
Member

No description provided.

@danielbachhuber danielbachhuber added this to the 2.0 Beta 12 milestone Feb 1, 2016
@danielbachhuber
Copy link
Member Author

@WP-API/amigos #reviewmerge

@TimothyBJacobs
Copy link
Member

This should ship with a giant warning that just because a user has the capability described, does not mean they will be able to perform the action.

@danielbachhuber
Copy link
Member Author

This should ship with a giant warning that just because a user has the capability described, does not mean they will be able to perform the action.

I think I understand what you're saying, but I'm not sure where it would fit in. How would you present such a warning?

rachelbaker added a commit that referenced this pull request Feb 1, 2016
Expose taxonomy and post type capabilities in `context==edit`
@rachelbaker rachelbaker merged commit df98f5c into develop Feb 1, 2016
@rachelbaker rachelbaker deleted the type-taxonomy-caps branch February 1, 2016 23:31
@nylen
Copy link
Member

nylen commented Feb 1, 2016

I think it makes sense to add a warning to the documentation, with an example of a case or two that can be problematic.

This change was prompted by some discussion in Slack: https://wordpress.slack.com/archives/core-restapi/p1454367860000776

To summarize - we do a lot of capabilities checking in Calypso, mainly so that we can go ahead and disable UI elements and/or show messages if we are certain that the user will not be able to perform an action. This isn't perfect - as you said, we still need to be sure we handle errors correctly - but it's still very useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing full-stop on the sentence here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants