This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Enforce min 1 and max 100 values for per_page arg#2209
Merged
Conversation
Member
Author
|
@WP-API/amigos #reviewmerge |
plugin.php
Outdated
Member
There was a problem hiding this comment.
It feels like we are just inventing this adhoc? What does it mean to have [ "type" => "string", "minimum" => 1 ]? For now, I'd be more in favour of just validating these in their own callback rather than abstracting rest_validate_request_arg to handle it until we have a solid spec on how to achieve this.
Member
Author
There was a problem hiding this comment.
It feels like we are just inventing this adhoc?
Huh? minimum and maximum are a part of the spec:
- https://github.com/json-schema/json-schema/wiki/Minimum-and-exclusiveminimum
- https://github.com/json-schema/json-schema/wiki/Maximum-and-exclusivemaximum
Although, I'll include a type check for integer and number
rmccue
added a commit
that referenced
this pull request
Feb 1, 2016
Enforce min 1 and max 100 values for `per_page` arg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1609