Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@danielbachhuber
Copy link
Member

Fixes #1609

@danielbachhuber danielbachhuber added this to the 2.0 Beta 12 milestone Feb 1, 2016
@danielbachhuber
Copy link
Member Author

@WP-API/amigos #reviewmerge

plugin.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we are just inventing this adhoc? What does it mean to have [ "type" => "string", "minimum" => 1 ]? For now, I'd be more in favour of just validating these in their own callback rather than abstracting rest_validate_request_arg to handle it until we have a solid spec on how to achieve this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rmccue added a commit that referenced this pull request Feb 1, 2016
Enforce min 1 and max 100 values for `per_page` arg
@rmccue rmccue merged commit 29490f2 into develop Feb 1, 2016
@rmccue rmccue deleted the 1609-min-max-validation branch February 1, 2016 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants