This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Only call sanitize_text_field() when sanitizing email
#2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sanitize_email()` also validates the email, and returns an empty string when the value is invalid, which is unexpected in a sanitization context. When sanitizing, we just want to make sure we have a reasonably safe string to work with.
danielbachhuber
added a commit
that referenced
this pull request
Jan 30, 2016
Only call `sanitize_text_field()` when sanitizing email
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanitize_email()also validates the email, and returns an empty stringwhen the value is invalid, which is unexpected in a sanitization
context. When sanitizing, we just want to make sure we have a reasonably
safe string to work with.
Daniel, Joe, and Ryan discussed this in person.
Fixes #1912