Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@danielbachhuber
Copy link
Member

Details historically in view have been moved to edit

Fixes #1869
Related #1845

Details historically in `view` have been moved to `edit`
@danielbachhuber danielbachhuber added this to the 2.0 Beta 12 milestone Jan 30, 2016
@danielbachhuber danielbachhuber self-assigned this Jan 30, 2016
@danielbachhuber danielbachhuber removed their assignment Jan 31, 2016
@danielbachhuber
Copy link
Member Author

@WP-API/amigos #reviewmerge

plugin.php Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm this is somewhat new behaviour, as this is really "array of type", the valid values being the enums. We might be better of using the jsonSchema way of doing this, rather than inventing our own.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I think I introduced this because roles ended up with an enum in my merge conflict:

'roles'           => array(
    'description' => __( 'Roles assigned to the resource.' ),
    'type'        => 'array',
    'context'     => array( 'edit' ),
    'enum'        => array_keys( $wp_roles->role_objects ),
),

I'll revert for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rmccue added a commit that referenced this pull request Feb 4, 2016
Provide `embed` and `view` as public contexts for users
@rmccue rmccue merged commit 8165a01 into develop Feb 4, 2016
@rmccue rmccue deleted the 1869-user-context branch February 4, 2016 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants