This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Use class variables for easier subclassing in Terms controller #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@WP-API/amigos #reviewmerge Although this doesn't cover all of the strings in the controller, I want to make sure the pattern is acceptable before I move on to other controllers. |
Member
|
👍 💯 I know Posts is one where I've hit the can't-override-namespace issue before, so good idea. |
rmccue
added a commit
that referenced
this pull request
Jan 27, 2016
Use class variables for easier subclassing in Terms controller
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2118