This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Use dynamic filter names for rest_post_query and rest_terms_query
#2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because these two controllers can be instantiated for different types and taxonomies, it makes sense for their filters to be named based on the type / taxonomy
Member
Author
|
@WP-API/amigos #reviewmerge |
danielbachhuber
added a commit
that referenced
this pull request
Jan 12, 2016
Use dynamic filter names for `rest_post_query` and `rest_terms_query`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because these two controllers can be instantiated for different types
and taxonomies, it makes sense for their filters to be named based on
the type / taxonomy
See #1167