This repository was archived by the owner on Sep 24, 2018. It is now read-only.
In prepare_date_response parse $date if available
#1951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes an issue where creating a new post with the API returned an object with all datetime fields set to null. * After this fix, the API properly returns parsed dates for `date` and `date_modified` and `null` for `date_gmt` and `date_modified_gmt`, matching the database state
Member
@adamsilverstein Can you share an example of this, so we have full history of the issue? |
Author
|
Sure, I am using the JS client to create a new post. the newly created post has null values returned for the date fields by the api before this patch. Before the patch the following two date values are null, after the patch they show the proper date: Before: After: |
rachelbaker
added a commit
that referenced
this pull request
Jan 12, 2016
…reating-post In `prepare_date_response` parse $date if available
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dateanddate_modifiedandnullfordate_gmtanddate_modified_gmt, matching the database state