This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Permit making a post sticky when also supplying an empty password #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@westonruter Can you update the tests to fix the build? |
Member
|
I'm not sure why this is required - this means I can't set a password to string |
Member
|
So the most precise check would be to ensure
|
westonruter
force-pushed
the
bugfix/use-empty-check-for-post-password
branch
from
eb4db30 to
b6a349d
Compare
Member
Author
|
Right, my choice of So instead of: if ( ! empty( $request['password'] ) ) {It should be: if ( isset( $request['password'] ) && '' !== $request['password'] ) {Amended commit in b6a349d. |
Member
|
@westonruter can you add to the |
danielbachhuber
added a commit
that referenced
this pull request
Jan 5, 2016
…sword Flag sticky if password not empty instead of isset
danielbachhuber
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If attempting to submit a
passwordconsisting of an empty string while also submitting true value forsticky, the API is returning an error:I believe it should be considering an empty string to be as if the value was not set.