Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Clean up permissions checks in WP_REST_Terms_Controller #1941

Merged
joehoyle merged 2 commits into from
Jan 4, 2016
Merged

Clean up permissions checks in WP_REST_Terms_Controller #1941

joehoyle merged 2 commits into from
Jan 4, 2016

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Jan 4, 2016

  • Use show_in_rest instead of public; rename method.
  • Return more descriptive WP_Error responses.
  • Move 404 check for update term for consistency.

@danielbachhuber
Clean up permissions checks in WP_REST_Terms_Controller
d4c0e27 
* Use `show_in_rest` instead of `public`; rename method.
* Return more descriptive `WP_Error` responses.
* Move 404 check for update term for consistency.
@danielbachhuber danielbachhuber added this to the 2.0 Beta 10 milestone Jan 4, 2016
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Jan 4, 2016

@WP-API/amigos #reviewmerge

joehoyle added a commit that referenced this pull request Jan 4, 2016
@joehoyle
Merge pull request #1941 from WP-API/taxonomy-term-permissions-check
b10e36d 
Clean up permissions checks in `WP_REST_Terms_Controller`
@joehoyle joehoyle merged commit b10e36d into develop Jan 4, 2016
@joehoyle joehoyle deleted the taxonomy-term-permissions-check branch January 4, 2016 23:09
@dave-green-uk dave-green-uk mentioned this pull request Jun 26, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Review

Projects

None yet

Milestone

2.0 Beta 10

Development

Successfully merging this pull request may close these issues.

3 participants

@danielbachhuber @joehoyle