This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Fix PHP docs. get_item is passed an array as opposed to a WP_REST_Request in several places.#1908
Closed
wpsmith wants to merge 1 commit intoWP-API:developfrom
Closed
Fix PHP docs. get_item is passed an array as opposed to a WP_REST_Request in several places.#1908wpsmith wants to merge 1 commit intoWP-API:developfrom
wpsmith wants to merge 1 commit intoWP-API:developfrom
Conversation
Member
|
Hm. I think we should be instantiating and using |
Member
|
Yeah I'd rather use a |
This was referenced Jan 4, 2016
Member
|
Thanks again for bringing this to our attention, @wpsmith. I've created pull requests to address each instance you've identified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_itemis passed an array as opposed to aWP_REST_Requestin several places (NOTE, line numbers may change but are correct at the time of submission):The way I see it there are 3 different possible fixes:
WP_REST_Requestget_itemto use a helper function to maintain type integrity though I am not sure what this would look like per se.