Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Permit creating comments without an assigned post #1857

Merged
rachelbaker merged 4 commits into from
Dec 15, 2015
Merged

Permit creating comments without an assigned post #1857

rachelbaker merged 4 commits into from
Dec 15, 2015

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Dec 13, 2015

Fixes #1805

@danielbachhuber danielbachhuber added this to the 2.0 Beta 10 milestone Dec 13, 2015
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Dec 13, 2015

@WP-API/amigos #reviewmerge

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Dec 13, 2015

Hm. I guess I need to wait for #1848 to land

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Dec 14, 2015

@WP-API/amigos updated. #reviewmerge

@rmccue
Copy link
Member

rmccue commented Dec 14, 2015

Should we allow this? Deferring to @rachelbaker's comment knowledge here.

@rachelbaker
Copy link
Member

rachelbaker commented Dec 14, 2015

@rmccue @danielbachhuber WordPress allows this programmatically, but not within the Dashboard admin. Are we trying to match data-model behavior (wp_insert_comment) or what the current WordPress allows?

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Dec 14, 2015

Data model behavior, imo

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Dec 14, 2015

Why would you permit querying for comments without a post (#1832) but not creating comments without a post?

rachelbaker added a commit that referenced this pull request Dec 15, 2015
@rachelbaker
Merge pull request #1857 from WP-API/1805-create-comments-without-post
3fa46e4 
Permit creating comments without an assigned post
@rachelbaker rachelbaker merged commit 3fa46e4 into develop Dec 15, 2015
@rachelbaker
Copy link
Member

rachelbaker commented Dec 15, 2015

@danielbachhuber Remember when I said:

We are actually unwinding Comments and their dependency on Posts in core. You can create Comments that aren't attached to Posts now (comment_post_ID is not required in wp_insert_comment()).

It is a slow process

@rachelbaker rachelbaker deleted the 1805-create-comments-without-post branch December 15, 2015 00:30
@dave-green-uk dave-green-uk mentioned this pull request Jun 26, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@rachelbaker rachelbaker

Labels

Review

Projects

None yet

Milestone

2.0 Beta 10

Development

Successfully merging this pull request may close these issues.

4 participants

@danielbachhuber @rmccue @rachelbaker