Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@danielbachhuber
Copy link
Member

collection should go to the collection of types and taxonomies,
respectively. While imperfect, item is the best definition we have for
the link to the collection of items.

From #1829 (comment)

`collection` should go to the collection of types and taxonomies,
respectively. While imperfect, `item` is the best definition we have for
the link to the collection of items.
@danielbachhuber danielbachhuber added this to the 2.0 Beta 9 milestone Dec 11, 2015
danielbachhuber added a commit that referenced this pull request Dec 11, 2015
Fix link relations for individual types and taxonomies
@danielbachhuber danielbachhuber merged commit aa20d7b into develop Dec 11, 2015
@danielbachhuber danielbachhuber deleted the fix-link-relations-types-taxonomies branch December 11, 2015 17:52
@joehoyle
Copy link
Member

I've seen a few PRs merged without review, was there communication somewhere else for peer review for these?

I don't think item is a correct relation - we should use a custom wp one if there is not the right relation already defined, we do this plenty elsewhere.

@rmccue
Copy link
Member

rmccue commented Dec 12, 2015

Agreed, we should DIY the relation here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants