This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Explicitly require post argument when creating a comment
#1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the internals require `post` when creating a comment, explicitly marking it as required will provide a more helpful error message when the argument isn't provided in the request.
Member
|
@danielbachhuber We are actually unwinding Comments and their dependency on Posts in core. You can create Comments that aren't attached to Posts now (comment_post_ID is not required in wp_insert_comment()). |
Member
Author
|
@rachelbaker Ah, makes sense. I've created a separate issue to eventually fix that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the internals require
postwhen creating a comment, explicitlymarking it as required will provide a more helpful error message when
the argument isn't provided in the request.
Discovered in #1453