Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Added saveComment #18

Closed
wants to merge 10 commits into from
Closed

Added saveComment #18

wants to merge 10 commits into from

Conversation

royboy789
Copy link

Added in a POST to /post/:id/comments to save a new comment

@Japh
Copy link
Contributor

Japh commented Nov 5, 2013

I'd like some input from @pippinsplugins or @rmccue before we merge this one.

Also, please update using the WordPress coding standards. Currently there are spaces missing from around parameters within parenthesis.

@royboy789
Copy link
Author

I readjusted the code to meet standards, sorry was kind of rushing as my application already had commenting. Will be adding delete shortly.

@rmccue
Copy link
Member

rmccue commented Nov 6, 2013

+1 on adding a comment endpoint, but we need heavy levels of sanitation and permission checking, so 👎 on the code as it stands.

@royboy789
Copy link
Author

Added in a new /users to pull all users, POST to add new user, and /user/:id to grab a single user

@rmccue
Copy link
Member

rmccue commented Nov 7, 2013

-1 on this PR. Separate features should be pulled into separate pull requests to ensure we're as modular as possible, plus it appears that there's merge/rebase artifacts in the PR.

That said, these would form a nice base for widget/user endpoints. I'll review these and rewrite when I'm back to full capacity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants