Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Add ?parent=<id> support for attachments; update Post _link #1777

Merged
joehoyle merged 2 commits into from
Nov 30, 2015
Merged

Add ?parent=<id> support for attachments; update Post _link #1777

joehoyle merged 2 commits into from
Nov 30, 2015

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Nov 30, 2015

Also stubs get_collection_params() abstraction for Posts controller to
make it possible for attachments controller to add ?parent=<id> support

Fixes #1767

@danielbachhuber
Add ?parent=<id> support for attachments; update Post _link
57b225c 
Also stubs `get_collection_params()` abstraction for Posts controller to
make it possible for attachments controller to add `?parent=<id>` support
@danielbachhuber danielbachhuber added this to the 2.0 Beta 8 milestone Nov 30, 2015
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Nov 30, 2015

@WP-API/amigos #reviewmerge

danielbachhuber
danielbachhuber reviewed Nov 30, 2015
View reviewed changes
lib/endpoints/class-wp-rest-posts-controller.php
Copy link
Member Author

@danielbachhuber danielbachhuber Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that's a little dodgy is that any controller extending this controller could use parent in the request, because we pass all arguments present in the request.

joehoyle added a commit that referenced this pull request Nov 30, 2015
@joehoyle
Merge pull request #1777 from WP-API/1767-parent-attachment
a524d40 
Add `?parent=<id>` support for attachments; update Post `_link`
@joehoyle joehoyle merged commit a524d40 into develop Nov 30, 2015
@joehoyle joehoyle deleted the 1767-parent-attachment branch November 30, 2015 17:40
@joehoyle joehoyle mentioned this pull request Nov 30, 2015
Closed
@danielbachhuber danielbachhuber mentioned this pull request Dec 10, 2015
Closed
@ioanlucut
Copy link

ioanlucut commented Jan 17, 2016

Hi! I am using version 2 Beta 10. Can you confirm that this functionality still works ? In my case, it really doesn't work. I am getting empty JSON back when I specify the parent request parameter. Thanks. (Wp v4.4.1)

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Jan 17, 2016

Can you confirm that this functionality still works ?

Yes, it does.

In my case, it really doesn't work. I am getting empty JSON back when I specify the parent request parameter.

Please open a new issue for support requests, and we'll help you debug the issue.

@ioanlucut
Copy link

ioanlucut commented Jan 18, 2016

Hi, thanks for your answer! Actually I found out why it doesn't work. It's because a media file can be attached only to one post, therefore by simply adding a new media to a post without checking if it's already attached to another one, doesn't mean it is associated with that specific post.

I find this really awkward, why can't a media item belong to more than one posts ? Anyways, I know this is a Wordpress issue.

Thanks a lot for your answer.

@danielbachhuber
Copy link
Member Author

danielbachhuber commented Jan 18, 2016

I find this really awkward, why can't a media item belong to more than one posts ? Anyways, I know this is a Wordpress issue.

Right — we still need to sort that out #1987

@dave-green-uk dave-green-uk mentioned this pull request Jun 26, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Review

Projects

None yet

Milestone

2.0 Beta 8

Development

Successfully merging this pull request may close these issues.

4 participants

@danielbachhuber @ioanlucut @joehoyle