This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Ensure post content doesn't get double-slashed on update #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, updating posts with quotes causes slashes to be saved to the db, as wp_update_post does `wp_slash` on already slashed data if you pass it an object. I'm not sure if this is the best fix, but the unit test illustrates the issue.
tests/test-rest-posts-controller.php
Outdated
Member
There was a problem hiding this comment.
Can we have an explicit test for the response title, to make this test more precise?
There was a problem hiding this comment.
I approve of this test. Also worth testing emoji and other unicode characters.
joehoyle
added a commit
that referenced
this pull request
Dec 1, 2015
Post updates should expect slashed data
danielbachhuber
changed the title
This was referenced Dec 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, updating posts with quotes causes slashes to be saved to the db, as
wp_update_post does
wp_slashon already slashed data if you pass it anobject.
I'm not sure if this is the best fix, but the unit test illustrates the issue.