This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Set fields=>id when using WP_User_Query to fix large memory usage #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The count query for the users should just pass the $fields => 'ID' param, otherwise WordPress will init a WP_User object for every user on the site, basically killing it.
Member
|
@joehoyle Did you mean to sneak the JS changes in? |
danielbachhuber
added a commit
that referenced
this pull request
Nov 30, 2015
Set the fields to 'id' fixing large memory usage
danielbachhuber
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The count query for the users should just pass the $fields => 'ID' param,
otherwise WordPress will init a WP_User object for every user on the site,
basically killing it.