This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Add Periods to Short, Long Dec and Inline Comments#1698
Merged
danielbachhuber merged 3 commits intoWP-API:developfrom Oct 29, 2015
Merged
Add Periods to Short, Long Dec and Inline Comments#1698danielbachhuber merged 3 commits intoWP-API:developfrom
danielbachhuber merged 3 commits intoWP-API:developfrom
Conversation
Add Periods to Short, Long Dec and Inline Comments
wp-api.js
Outdated
Member
There was a problem hiding this comment.
I'm not sure it makes sense to add a period here, as it changes the nature of the URL.
Contributor
Author
There was a problem hiding this comment.
Let me re-submit this PR and I will add @link tags for these URLs without a period at the end, as suggested in the core handbook.
wp-api.js
Outdated
Member
|
There are a number of instances where the period needs to be removed. |
Contributor
Author
|
@danielbachhuber I have updated the file and removed the unnecessary periods. |
danielbachhuber
added a commit
that referenced
this pull request
Oct 29, 2015
Add Periods to Short, Long Dec and Inline Comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit Adda Periods to Short, Long Dec and Inline Comments in accordance with WP JS documentation standards.