Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Expose date_gmt for view context of Posts and Comments #1690

Merged
rachelbaker merged 1 commit into from
Oct 30, 2015
Merged

Expose date_gmt for view context of Posts and Comments #1690

rachelbaker merged 1 commit into from
Oct 30, 2015

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Oct 25, 2015

It can be useful for determining the absolute time for the resource.

date_gmt was set for edit context only in
29c768b and
a12c23a

See #1675

@danielbachhuber
Expose date_gmt for view context of Posts and Comments
983b5ec 
It can be useful for determining the absolute time for the resource.

`date_gmt` was set for `edit` context only in
29c768b and
a12c23a
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Oct 25, 2015

@WP-API/amigos #reviewmerge

@rachelbaker Do you recall why you moved comment_date_gmt to edit context in 29c768b ?

@danielbachhuber danielbachhuber added this to the 2.0 Beta 6 milestone Oct 25, 2015
@danielbachhuber danielbachhuber mentioned this pull request Oct 25, 2015
Closed
@rachelbaker
Copy link
Member

rachelbaker commented Oct 30, 2015

@danielbachhuber the original philosophy I was trying to adhere to was is this property used for front-end public display? I have never seen a theme that displayed the post_date and separately also post_date_gmt.
That being said, I notice that we do expose modified_gmt for Posts....so we should be consistent one way or the other. I am 👍 with including the _gmt dates in the view context.

rachelbaker added a commit that referenced this pull request Oct 30, 2015
@rachelbaker
Merge pull request #1690 from WP-API/1675-date-gmt-post-comment
de2e583 
Expose `date_gmt` for `view` context of Posts and Comments
@rachelbaker rachelbaker merged commit de2e583 into develop Oct 30, 2015
@rachelbaker rachelbaker deleted the 1675-date-gmt-post-comment branch October 30, 2015 18:57
@dave-green-uk dave-green-uk mentioned this pull request Jun 26, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@rachelbaker rachelbaker

Labels

Review

Projects

None yet

Milestone

2.0 Beta 6

Development

Successfully merging this pull request may close these issues.

3 participants

@danielbachhuber @rachelbaker