Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@rmccue
Copy link
Member

@rmccue rmccue commented Oct 12, 2015

Fixes #1639.

This changed in trunk's r34997. term_taxonomy_id now always succeeds,
even if the taxonomy specified does not match, so we need to
double-check this ourselves.
@rmccue rmccue added this to the 2.0 Beta 5 milestone Oct 12, 2015
@rmccue rmccue added the Review label Oct 12, 2015
@rmccue
Copy link
Member Author

rmccue commented Oct 12, 2015

@WP-API/amigos Should be good to go; main substance is changing the taxonomy check. get_term_by started always returning the term in r34997 when you pass term_taxonomy_id, even if the taxonomy doesn't match, so we need to double-check.

danielbachhuber added a commit that referenced this pull request Oct 12, 2015
Fix tests with latest trunk
@danielbachhuber danielbachhuber merged commit 35e37c6 into develop Oct 12, 2015
@danielbachhuber danielbachhuber deleted the fix-tests branch October 12, 2015 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants