This repository was archived by the owner on Sep 24, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 651
Sort out link relations and embedded data #1284
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows proper inheritance and overriding in subclasses.
There shouldn't be a 2.1 or similar, since we're sticking to integer versions, so no need to have this.
Member
Author
|
(Also, this leaves us with one non-IANA-registered link relation, |
Member
|
Will also fix #1289 |
Conflicts: lib/endpoints/class-wp-rest-revisions-controller.php
Member
Author
|
@WP-API/amigos #reviewmerge |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rachelbaker
added a commit
that referenced
this pull request
May 26, 2015
Sort out link relations and embedded data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start to fix #1139.
Right now, this still uses the custom relation types, but next step is going to be trying switching that over.
I've also gone through and added a lot more fields to the embed context to make these links actually useful. Now you can go and get everything to render a single post nice and easily (example post with embedding).
Also fixes #1289, fixes #1287