Skip to content
This repository was archived by the owner on Sep 24, 2018. It is now read-only.

Conversation

@danielbachhuber
Copy link
Member

Fixes #534

@danielbachhuber
Copy link
Member Author

@WP-API/amigos #reviewmerge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielbachhuber Many hosts limit the size of HTTP headers. I don't know if we ran into this issue with v1.0, but I believe @rmccue and I discussed moving these values into the collection response itself. @rmccue am I recalling correctly??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to implement as headers for now, as it follows the existing implementation, and we can reformat at a later date in this milestone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we ran into this issue with v1.0

We definitely did, WP Engine limits more aggressively than other hosts and we saw problems there. That was only because we sent one-link-per-item though.

Should be fine here (we do the same for posts) for now, I think the plan was to review when we look at the links-for-collections stuff

rachelbaker added a commit that referenced this pull request May 6, 2015
Add pagination headers to term collection response
@rachelbaker rachelbaker merged commit c4378d6 into develop May 6, 2015
@rachelbaker rachelbaker deleted the 534-term-query-pagination branch May 6, 2015 16:28
@rachelbaker
Copy link
Member

Merged #1182

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paginate terms queries and limit by default

3 participants