This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Retool WP_REST_Terms_Controller to follow Posts controller pattern
#1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By passing the taxonomy to the controller, we can more easily allow custom controllers for taxonomies, and for those custom taxonomies to have custom schemas
Member
Author
|
@WP-API/amigos #reviewmerge |
Member
|
Haven't tested, but 👍 on concept. |
Member
Author
Cool. All existing tests pass. |
danielbachhuber
pushed a commit
that referenced
this pull request
May 4, 2015
Retool `WP_REST_Terms_Controller` to follow Posts controller pattern
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing the taxonomy to the controller, we can more easily allow
custom controllers for taxonomies, and for those custom taxonomies to
have custom schemas
Fixes #1061
See also #899