tests + respect for spacing convention

vlood · vlood · commit c5f618a2712c · 2015-02-11T18:29:24.000+02:00
diff --git a/lib/class-wp-json-posts.php b/lib/class-wp-json-posts.php
@@ -423,8 +423,8 @@ protected function check_read_permission( $post ) {
 		}
 		
 		//In case we are dealing with custom post status, check if it's public
-		$post_status_obj = get_post_status_object($post['post_status']);
-		if ($post_status_obj->public){
+		$post_status_obj = get_post_status_object( $post['post_status'] );
+		if ( $post_status_obj->public ){
 			return true;
 		}
 
diff --git a/tests/test-json-posts.php b/tests/test-json-posts.php
@@ -666,5 +666,62 @@ function test_edit_post_sticky_false() {
 
 		$this->assertFalse( is_sticky( $this->post_id ) );
 	}
+    
+    
+    function test_check_read_permission() {
+        $publicstatusargs = array(
+            'label'                     => _x( 'testpublicstatus', 'Status General Name', 'wp-api' ),
+            'label_count'               => _n_noop( 'Testpublicstatus (%s)',  'Testpublicstatuses (%s)', 'wp-api' ), 
+            'public'                    => true,
+            'show_in_admin_all_list'    => true,
+            'show_in_admin_status_list' => true,
+            'exclude_from_search'       => false,
+        );
+        register_post_status( 'testpublicstatus', $publicstatusargs );
+        
+        $privatestatusargs = array(
+            'label'                     => _x( 'testprivatestatus', 'Status General Name', 'wp-api' ),
+            'label_count'               => _n_noop( 'Testprivatestatus (%s)',  'Testprivatestatuses (%s)', 'wp-api' ), 
+            'public'                    => false,
+            'show_in_admin_all_list'    => true,
+            'show_in_admin_status_list' => true,
+            'exclude_from_search'       => false,
+        );
+        register_post_status( 'testprivatestatus', $privatestatusargs );
+        
+        $publiccustom_args = array(
+            'post_content'   => 'this one is with a public status',
+            'post_name'      => 'publicstatus-post',
+            'post_title'     => 'Post with a custom public status',
+            'post_status'    => 'testpublicstatus'
+        );
+        
+        $privatecustom_args = array(
+            'post_content'   => 'this one is with a private status',
+            'post_name'      => 'privatestatus-post',
+            'post_title'     => 'Post with a custom private status',
+            'post_status'    => 'testprivatestatus'
+        );
+        
+        $publish_args = array(
+            'post_content'   => 'this one is with a publish status',
+            'post_name'      => 'publish-post',
+            'post_title'     => 'Post with publish status',
+            'post_status'    => 'publish'
+        );
+        
+        $publiccustom_pid = wp_insert_post( $publiccustom_args );
+        $privatecustom_pid = wp_insert_post( $privatecustom_args );
+        $publish_pid = wp_insert_post( $publish_args );
+        
+        $pub_cust_post = get_post( $publiccustom_pid, ARRAY_A );
+        $priv_cust_post = get_post( $privatecustom_pid, ARRAY_A );
+        $pub_post = get_post( $publish_pid, ARRAY_A );
+        
+        $this->assertTrue($pub_cust_post);
+        $this->assertFalse($priv_cust_post);
+        $this->assertTrue($pub_post);
+    }
+    
 
 }

Original file line number	Diff line number	Diff line change
`@@ -423,8 +423,8 @@ protected function check_read_permission( $post ) {`
`423`	`423`	`}`
`424`	`424`
`425`	`425`	`//In case we are dealing with custom post status, check if it's public`
`426`		`- $post_status_obj = get_post_status_object($post['post_status']);`
`427`		`- if ($post_status_obj->public){`
	`426`	`+ $post_status_obj = get_post_status_object( $post['post_status'] );`
	`427`	`+ if ( $post_status_obj->public ){`
`428`	`428`	`return true;`
`429`	`429`	`}`
`430`	`430`