Merge pull request #1973 from WP-API/1959-fix-query-media

joehoyle · joehoyle · commit 7573f8a19e36 · 2016-01-08T15:50:39.000-05:00
Permit logged-in users to query for media
diff --git a/lib/endpoints/class-wp-rest-posts-controller.php b/lib/endpoints/class-wp-rest-posts-controller.php
@@ -1604,7 +1604,7 @@ public function get_collection_params() {
 			),
 		);
 		$params['status'] = array(
-			'default'           => 'publish',
+			'default'           => 'attachment' === $this->post_type ? 'inherit' : 'publish',
 			'description'       => __( 'Limit result set to posts assigned a specific status.' ),
 			'sanitize_callback' => 'sanitize_key',
 			'type'              => 'string',
@@ -1625,7 +1625,7 @@ public function get_collection_params() {
 	 * @return WP_Error|bool
 	 */
 	public function validate_user_can_query_private_statuses( $value, $request, $parameter ) {
-		if ( 'publish' === $value ) {
+		if ( 'publish' === $value || ( 'attachment' === $this->post_type && 'inherit' === $value ) ) {
 			return true;
 		}
 		$post_type_obj = get_post_type_object( $this->post_type );
diff --git a/tests/test-rest-attachments-controller.php b/tests/test-rest-attachments-controller.php
@@ -65,6 +65,33 @@ public function test_get_items() {
 		$this->check_get_posts_response( $response );
 	}
 
+	public function test_get_items_logged_in_editor() {
+		wp_set_current_user( $this->editor_id );
+		$id1 = $this->factory->attachment->create_object( $this->test_file, 0, array(
+			'post_mime_type' => 'image/jpeg',
+			'post_excerpt'   => 'A sample caption',
+		) );
+		$draft_post = $this->factory->post->create( array( 'post_status' => 'draft' ) );
+		$id2 = $this->factory->attachment->create_object( $this->test_file, $draft_post, array(
+			'post_mime_type' => 'image/jpeg',
+			'post_excerpt'   => 'A sample caption',
+		) );
+		$published_post = $this->factory->post->create( array( 'post_status' => 'publish' ) );
+		$id3 = $this->factory->attachment->create_object( $this->test_file, $published_post, array(
+			'post_mime_type' => 'image/jpeg',
+			'post_excerpt'   => 'A sample caption',
+		) );
+		$request = new WP_REST_Request( 'GET', '/wp/v2/media' );
+		$response = $this->server->dispatch( $request );
+
+		$data = $response->get_data();
+		$this->assertCount( 3, $data );
+		$ids = wp_list_pluck( $data, 'id' );
+		$this->assertTrue( in_array( $id1, $ids ) );
+		$this->assertTrue( in_array( $id2, $ids ) );
+		$this->assertTrue( in_array( $id3, $ids ) );
+	}
+
 	public function test_get_items_parent() {
 		$post_id = $this->factory->post->create( array( 'post_title' => 'Test Post' ) );
 		$attachment_id = $this->factory->attachment->create_object( $this->test_file, $post_id, array(
