This repository was archived by the owner on Jan 28, 2026. It is now read-only.
Conversation
panva
approved these changes
Dec 9, 2021
Merged
twiss
added a commit
that referenced
this pull request
Aug 30, 2023
The `alg` field is not required and might change in the future, see https://www.ietf.org/archive/id/draft-jones-jose-fully-specified-algorithms-00.html. * Revert "Set and check "alg" JWK property for EdDSA keys (#3)" This reverts commit bf5f161. * Revert "Update JWK mappings for Ed25519 and Ed448 (#4)" This reverts commit 5d58d49.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@panva This is a fairly trivial change but perhaps you still feel like reviewing?