Rename private to local by johnathan79717 · Pull Request #97 · WICG/private-network-access

johnathan79717 · 2023-01-18T18:14:15Z

Fixes #91

yoavweiss · 2023-01-19T04:36:52Z

Hey @johnathan79717 - can you join the WICG to appease the IPR bots? :)

johnathan79717 · 2023-01-20T10:36:39Z

Ah right. I requested to join WICG just now.

I have kept the header names the same until we decide what to do with it. I'll probably need to modify the explainers if we're gonna go through with this. Did I miss anything else?

annevk · 2023-01-20T11:18:15Z

Please file explicit follow-up issues for things that are not renamed since you plan on closing the initial issue once this lands.

johnathan79717 · 2023-01-20T11:27:29Z

Please file explicit follow-up issues for things that are not renamed since you plan on closing the initial issue once this lands.

Good point. I removed the keyword in the description so it should not close the initial issue now.

johnathan79717 · 2023-01-25T15:19:07Z

Closing this as we decided against renaming. See WICG/local-network-access#97

johnathan79717 · 2023-02-21T16:20:01Z

Reopening this PR since renaming is back on the table.

letitz · 2023-02-23T09:19:51Z

Let me know when this is ready for review.

johnathan79717 · 2023-02-23T10:30:39Z

Let me know when this is ready for review.

It is ready for review. 😄

letitz · 2023-02-23T10:35:07Z

Perfect! I shall start reviewing then :)

letitz

Looks good! I think we also want to update the base explainer.md file, right?

letitz

Thanks very much! One last suggestion and we can merge.

…t.cc In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in web_view_browsertest.cc. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: I52fa91a66f225f7076cc1f1d4a9068c0ea880d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335665 Reviewed-by: Kevin McNee <[email protected]> Auto-Submit: Jonathan Hao <[email protected]> Reviewed-by: Bo Liu <[email protected]> Commit-Queue: Bo Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1117536}

… local In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in content browser clients. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Ied4716aa17e0c401a147e520341def36202fd31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334479 Reviewed-by: Yuchen Liu <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Reviewed-by: Camille Lamy <[email protected]> Reviewed-by: Bo Liu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1117583}

…sertest.cc In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in interest_group_browsertest.cc. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: If1f8bbc9c5e8d87c8761dcf33ba41abd60114da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336326 Reviewed-by: Caleb Raitto <[email protected]> Auto-Submit: Jonathan Hao <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1117589}

…ics.md In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in web_mitigation_metrics.md. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: If5d23739cba049908731f5fa97aff9f79a4037cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334390 Reviewed-by: Titouan Rigoudy <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1118030}

In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in net log events. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Idc3dcaee7d761b64d0d92ed393899334445e0541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336324 Reviewed-by: Kenichi Ishibashi <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1118082}

In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in net errors. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Id6338a3efb6ab2e5f31a8488240e611e8a7ffc47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334570 Reviewed-by: Kenichi Ishibashi <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1118158}

In WICG/local-network-access#91, we decided to rename (public, private, local) IP address spaces to (public, local, loopback). The spec has already been renamed in WICG/local-network-access#97. New spec: https://wicg.github.io/local-network-access/#ip-address-space-heading This CL renames the string representation in request.cc. It also updates a mixed content wpt because it uses targetAddressSpace defined in Request. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115707}

In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in wpt file names. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033 Commit-Queue: Jonathan Hao <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115802}

In WICG/local-network-access#91, we decided to rename (public, private, local) IP address spaces to (public, local, loopback). The spec has already been renamed in WICG/local-network-access#97. New spec: https://wicg.github.io/local-network-access/#ip-address-space-heading This CL renames the string representation in request.cc. It also updates a mixed content wpt because it uses targetAddressSpace defined in Request. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115707}

In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in wpt file names. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033 Commit-Queue: Jonathan Hao <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115802}

… local in request.cc, a=testonly Automatic update from web-platform-tests [Local Network Access] Rename private to local in request.cc In WICG/local-network-access#91, we decided to rename (public, private, local) IP address spaces to (public, local, loopback). The spec has already been renamed in WICG/local-network-access#97. New spec: https://wicg.github.io/local-network-access/#ip-address-space-heading This CL renames the string representation in request.cc. It also updates a mixed content wpt because it uses targetAddressSpace defined in Request. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115707} -- wpt-commits: 4af24bc53abf0e57acfc0e2c2d3ff62787e79c79 wpt-pr: 38855

… local in WPTs, a=testonly Automatic update from web-platform-tests [Local Network Access] Rename private to local in WPTs In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in wpt file names. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033 Commit-Queue: Jonathan Hao <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115802} -- wpt-commits: d7f32fa18f99177e1e5834b3995e33f28d1865b5 wpt-pr: 38935

In WICG/local-network-access#91, we decided to rename (public, private, local) IP address spaces to (public, local, loopback). The spec has already been renamed in WICG/local-network-access#97. New spec: https://wicg.github.io/local-network-access/#ip-address-space-heading This CL renames the string representation in request.cc. It also updates a mixed content wpt because it uses targetAddressSpace defined in Request. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 Reviewed-by: Camille Lamy <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115707}

In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ This CL renames PrivateNetwork to LocalNetwork in wpt file names. There are so many places to rename, so during the process, there will inevitably be inconsistencies. Hopefully, we shall resolve all of them soon. Bug: 1418287 Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033 Commit-Queue: Jonathan Hao <[email protected]> Reviewed-by: Weizhong Xia <[email protected]> Cr-Commit-Position: refs/heads/main@{#1115802}

This reverts commit 09f21d8c48ebc54193b12874c895648c69dfbe92. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in WPTs > > In WICG/local-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/local-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in wpt file names. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: I10ef6762b72fb10ac88525b13a674237628e9055 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4329033 > Commit-Queue: Jonathan Hao <[email protected]> > Reviewed-by: Weizhong Xia <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1115802} Bug: 1418287 Change-Id: I8f29e58c4a0e8741be98bc9fd640510e1473e61c

…ion_metrics.md" This reverts commit 7893736. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in web_mitigation_metrics.md > > In WICG/local-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/local-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in > web_mitigation_metrics.md. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: If5d23739cba049908731f5fa97aff9f79a4037cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334390 > Reviewed-by: Titouan Rigoudy <[email protected]> > Commit-Queue: Jonathan Hao <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1118030} Bug: 1418287 Change-Id: Icc21a4fc48a12e85038c017a1f0821a6660f0f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670561 Commit-Queue: Jonathan Hao <[email protected]> Reviewed-by: Yifan Luo <[email protected]> Cr-Commit-Position: refs/heads/main@{#1168121}

…oup_browsertest.cc" This reverts commit c6a9a9a. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in interest_group_browsertest.cc > > In WICG/local-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/local-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in > interest_group_browsertest.cc. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > > Change-Id: If1f8bbc9c5e8d87c8761dcf33ba41abd60114da0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4336326 > Reviewed-by: Caleb Raitto <[email protected]> > Auto-Submit: Jonathan Hao <[email protected]> > Commit-Queue: Jonathan Hao <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1117589} Bug: 1418287 Change-Id: I476f0f99ee9d6192ad6ffa7080a70c240a1e9ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4669624 Reviewed-by: Caleb Raitto <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1168148}

…owsertest.cc" This reverts commit cdd0a01. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in web_view_browsertest.cc > > In WICG/local-network-access#91, we decided to > rename Private Network Access to Local Network Access. The spec has > already been renamed in > WICG/local-network-access#97. The latest spec: > https://wicg.github.io/local-network-access/ > > This CL renames PrivateNetwork to LocalNetwork in > web_view_browsertest.cc. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > > Change-Id: I52fa91a66f225f7076cc1f1d4a9068c0ea880d82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335665 > Reviewed-by: Kevin McNee <[email protected]> > Auto-Submit: Jonathan Hao <[email protected]> > Reviewed-by: Bo Liu <[email protected]> > Commit-Queue: Bo Liu <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1117536} Bug: 1418287 Change-Id: I4658cb3f7ee33e7ab89c0a290dc551db79022828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4671591 Reviewed-by: Bo Liu <[email protected]> Auto-Submit: Jonathan Hao <[email protected]> Quick-Run: Jonathan Hao <[email protected]> Reviewed-by: Ted Choc <[email protected]> Commit-Queue: Ted Choc <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1168202}

… local" This reverts commit 262019a. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename content setting from private to local > > In WICG/local-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback) and rename the spec to Local Network Access. The spec has > already been renamed in > WICG/local-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the occurrences in content settings. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: I5f1e6bfc5fcda6598e761eb201274ea9409609f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335304 > Reviewed-by: Christian Dullweber <[email protected]> > Commit-Queue: Jonathan Hao <[email protected]> > Reviewed-by: Ted Choc <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1117088} Bug: 1418287 Change-Id: I3a3afd97546650506410d57b81831ee63404dc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670562 Reviewed-by: Ted Choc <[email protected]> Commit-Queue: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1168233}

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/local-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/local-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <[email protected]> > Commit-Queue: Jonathan Hao <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac

This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/local-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/local-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <[email protected]> > Commit-Queue: Jonathan Hao <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564 Reviewed-by: Arthur Hemery <[email protected]> Commit-Queue: Arthur Hemery <[email protected]> Auto-Submit: Jonathan Hao <[email protected]> Quick-Run: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1168815}

In WICG/local-network-access#91, we decided to rename Private Network Access to Local Network Access. The spec has already been renamed in WICG/local-network-access#97. The latest spec: https://wicg.github.io/local-network-access/ Chromium has also renamed private to local in https://source.chromium.org/chromium/chromium/src/+/d5b320062c4982d2e215386e068826f8bc97c512 so the ip-address-overrides switch value needs to be updated too. This PR makes the corresponding changes in the RFC.

…ivate to local in request.cc", a=testonly Automatic update from web-platform-tests Revert "[Local Network Access] Rename private to local in request.cc" This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/local-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/local-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <[email protected]> > Commit-Queue: Jonathan Hao <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564 Reviewed-by: Arthur Hemery <[email protected]> Commit-Queue: Arthur Hemery <[email protected]> Auto-Submit: Jonathan Hao <[email protected]> Quick-Run: Jonathan Hao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1168815} -- wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b wpt-pr: 40968

…ivate to local in request.cc", a=testonly Automatic update from web-platform-tests Revert "[Local Network Access] Rename private to local in request.cc" This reverts commit 3037cbc62a25a6a929e6c8cbc3ea41b23df18960. Reason for revert: The spec has been renamed back to Private Network Access WICG/private-network-access#106 Original change's description: > [Local Network Access] Rename private to local in request.cc > > In WICG/local-network-access#91, we decided to > rename (public, private, local) IP address spaces to (public, local, > loopback). The spec has already been renamed in > WICG/local-network-access#97. > New spec: > https://wicg.github.io/local-network-access/#ip-address-space-heading > > This CL renames the string representation in request.cc. It also updates > a mixed content wpt because it uses targetAddressSpace defined in > Request. > > There are so many places to rename, so during the process, there will > inevitably be inconsistencies. Hopefully, we shall resolve all of them > soon. > > Bug: 1418287 > Change-Id: Ib01eb5385626c410d2b5f2bba4a67b86a28380d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4317043 > Reviewed-by: Camille Lamy <clamychromium.org> > Commit-Queue: Jonathan Hao <phaochromium.org> > Cr-Commit-Position: refs/heads/main{#1115707} Bug: 1418287 Change-Id: I7c7f1abb26e31c9b5a9531000aa572d16ef0f3ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4670564 Reviewed-by: Arthur Hemery <ahemerychromium.org> Commit-Queue: Arthur Hemery <ahemerychromium.org> Auto-Submit: Jonathan Hao <phaochromium.org> Quick-Run: Jonathan Hao <phaochromium.org> Cr-Commit-Position: refs/heads/main{#1168815} -- wpt-commits: 0b9e87dcaa97a472760b165f20679338ddcbf30b wpt-pr: 40968 UltraBlame original commit: 3363e3ba006e3d6813284cdf2adfcade6c21df88

johnathan79717 changed the title ~~Rename private to local~~ [WIP] Rename private to local Jan 20, 2023

johnathan79717 closed this Jan 25, 2023

johnathan79717 deleted the rename-private-to-local branch January 25, 2023 15:19

johnathan79717 restored the rename-private-to-local branch January 27, 2023 16:01

johnathan79717 added 4 commits February 21, 2023 16:04

make force

57508c4

Rename local to loopback

71ce97b

Rename private to local

4f10a7d

Update header names

192dba3

johnathan79717 reopened this Feb 21, 2023

johnathan79717 force-pushed the rename-private-to-local branch from 4ff30f6 to c07640f Compare February 21, 2023 16:19

johnathan79717 marked this pull request as ready for review February 21, 2023 16:20

johnathan79717 changed the title ~~[WIP] Rename private to local~~ Rename private to local Feb 21, 2023

letitz mentioned this pull request Feb 21, 2023

Consider avoiding the use of the word "private" #91

Open

Update docs other than the main spec

6210c46

johnathan79717 force-pushed the rename-private-to-local branch from c07640f to 6210c46 Compare February 22, 2023 13:38

letitz requested changes Feb 23, 2023

View reviewed changes

Comment thread HOWTO.md

Comment thread README.md

Rename explainer and add note under README

4a42bab

letitz requested changes Feb 24, 2023

View reviewed changes

Comment thread README.md Outdated

Append note about previous naming

f363c84

letitz merged commit 72aa00c into WICG:main Feb 24, 2023

johnathan79717 deleted the rename-private-to-local branch February 27, 2023 10:02

latin-1 mentioned this pull request Apr 9, 2023

rename private-network-access feature actix/actix-extras#320

Merged

4 tasks

chromium-wpt-export-bot mentioned this pull request Jul 10, 2023

Revert "[Local Network Access] Rename private to local in WPTs" web-platform-tests/wpt#40948

Closed

chromium-wpt-export-bot mentioned this pull request Jul 11, 2023

Revert "[Local Network Access] Rename private to local in request.cc" web-platform-tests/wpt#40968

Merged

Uh oh!

Conversation

johnathan79717 commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yoavweiss commented Jan 19, 2023

Uh oh!

johnathan79717 commented Jan 20, 2023

Uh oh!

annevk commented Jan 20, 2023

Uh oh!

johnathan79717 commented Jan 20, 2023

Uh oh!

johnathan79717 commented Jan 25, 2023

Uh oh!

johnathan79717 commented Feb 21, 2023

Uh oh!

letitz commented Feb 23, 2023

Uh oh!

johnathan79717 commented Feb 23, 2023

Uh oh!

letitz commented Feb 23, 2023

Uh oh!

letitz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

letitz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

johnathan79717 commented Jan 18, 2023 •

edited

Loading