Fix behavior of ring_span's copy_popper<T>, and general popper cleanup. #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes WG21-SG14#91. Apparently the typo `t` for `old` is also in the current paper http://wg21.link/p0059r3 — we should fix that too! Fixes WG21-SG14#102.
Quuxplusone
commented
May 19, 2017
| T old = m_copy; | ||
| using std::swap; | ||
| swap(old, t); | ||
| return old; |
Contributor
Author
There was a problem hiding this comment.
This dance makes the operation exception-safe, in case that matters. If copying m_copy into old throws an exception, then the swap doesn't happen and the value of t is preserved.
Quuxplusone
commented
May 19, 2017
| copy_popper(T&& t); | ||
| T operator()(T& t); | ||
| T copy; | ||
| explicit copy_popper(T t); |
Contributor
Author
There was a problem hiding this comment.
Notice that I'm changing this from T&& to just T, which fixes #102 in an elegant way. I don't think there's any downside to this change.
Contributor
There was a problem hiding this comment.
The explicit broke one of the tests included here: aba9766#commitcomment-22430301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91. Apparently the typo
tforoldis also in the currentpaper http://wg21.link/p0059r3 — we should fix that too!
Fixes #102.