Repository navigation
Commit 23963d0
fix: Operator Cluster Role grants excess permissions (feast-dev#302)
* Fix: [RHOAI 3.5] Operator Cluster Role grants excess permissions
Signed-off-by: Jitendra Yejare <[email protected]>
Co-authored-by: Cursor <[email protected]>
* fix: Restore pods/exec create in operator manager-role for CronJob support
The security hardening commit stripped pods/exec create from the
operator manager-role. The CronJob feature creates a Role granting
pods/exec create to the FeatureStore SA for running feast apply
and materialize commands. Without this permission, Kubernetes RBAC
escalation prevention blocks the Role creation.
Signed-off-by: Jitendra Yejare <[email protected]>
Co-authored-by: Cursor <[email protected]>
* fix: Remove inert subjectaccessreviews and restore clusterrolebindings list
The operator manager-role had subjectaccessreviews stripped by the
security hardening commit. When the default auth was changed to
kubernetes, the reconciler tries to create Roles/ClusterRoles
granting subjectaccessreviews create to the FeatureStore SA.
Kubernetes RBAC escalation prevention blocks this because the
operator SA no longer has this permission, causing reconciliation
failure.
- Remove subjectaccessreviews create from both setFeastRole() and
setFeastClusterRole() — it was under rbac.authorization.k8s.io
(wrong API group; real SAR is authorization.k8s.io) and was inert
- Add clusterrolebindings list back to the operator manager-role
so the feast SA can resolve ClusterRoleBinding-based user roles
via list_cluster_role_binding() in the Python SDK
Signed-off-by: Jitendra Yejare <[email protected]>
Co-authored-by: Cursor <[email protected]>
---------
Signed-off-by: Jitendra Yejare <[email protected]>
Co-authored-by: Cursor <[email protected]>1 parent 18606e5 commit 23963d0
5 files changed
Lines changed: 111 additions & 21 deletions
File tree
- infra/feast-operator
- bundle/manifests
- config/rbac
- dist
- internal/controller
- authz
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
140 | 148 | | |
141 | | - | |
142 | 149 | | |
143 | 150 | | |
144 | 151 | | |
| |||
149 | 156 | | |
150 | 157 | | |
151 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
152 | 165 | | |
153 | 166 | | |
154 | 167 | | |
| |||
202 | 215 | | |
203 | 216 | | |
204 | 217 | | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
205 | 227 | | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
206 | 245 | | |
207 | 246 | | |
208 | | - | |
209 | 247 | | |
210 | 248 | | |
211 | 249 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | 88 | | |
90 | 89 | | |
91 | 90 | | |
92 | 91 | | |
93 | 92 | | |
94 | 93 | | |
95 | | - | |
96 | 94 | | |
97 | 95 | | |
98 | 96 | | |
| |||
103 | 101 | | |
104 | 102 | | |
105 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
106 | 110 | | |
107 | 111 | | |
108 | 112 | | |
| |||
164 | 168 | | |
165 | 169 | | |
166 | 170 | | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
167 | 190 | | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
168 | 198 | | |
169 | 199 | | |
170 | | - | |
171 | 200 | | |
172 | 201 | | |
173 | 202 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20451 | 20451 | | |
20452 | 20452 | | |
20453 | 20453 | | |
20454 | | - | |
20455 | 20454 | | |
20456 | 20455 | | |
20457 | 20456 | | |
20458 | 20457 | | |
20459 | 20458 | | |
20460 | 20459 | | |
20461 | | - | |
20462 | 20460 | | |
20463 | 20461 | | |
20464 | 20462 | | |
| |||
20469 | 20467 | | |
20470 | 20468 | | |
20471 | 20469 | | |
| 20470 | + | |
| 20471 | + | |
| 20472 | + | |
| 20473 | + | |
| 20474 | + | |
| 20475 | + | |
20472 | 20476 | | |
20473 | 20477 | | |
20474 | 20478 | | |
| |||
20530 | 20534 | | |
20531 | 20535 | | |
20532 | 20536 | | |
| 20537 | + | |
| 20538 | + | |
| 20539 | + | |
| 20540 | + | |
| 20541 | + | |
| 20542 | + | |
| 20543 | + | |
| 20544 | + | |
| 20545 | + | |
| 20546 | + | |
| 20547 | + | |
| 20548 | + | |
| 20549 | + | |
| 20550 | + | |
| 20551 | + | |
| 20552 | + | |
| 20553 | + | |
| 20554 | + | |
| 20555 | + | |
20533 | 20556 | | |
| 20557 | + | |
| 20558 | + | |
| 20559 | + | |
| 20560 | + | |
| 20561 | + | |
| 20562 | + | |
| 20563 | + | |
20534 | 20564 | | |
20535 | 20565 | | |
20536 | | - | |
20537 | 20566 | | |
20538 | 20567 | | |
20539 | 20568 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | 152 | | |
158 | 153 | | |
159 | 154 | | |
| |||
235 | 230 | | |
236 | 231 | | |
237 | 232 | | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | 233 | | |
244 | 234 | | |
245 | 235 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
70 | | - | |
71 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
72 | 75 | | |
| 76 | + | |
73 | 77 | | |
74 | 78 | | |
75 | 79 | | |
| |||
0 commit comments