feat: Add RSA KeyStore attestation support#4
Merged
VisionR1 merged 1 commit intoVisionR1:masterfrom Jul 7, 2025
Merged
Conversation
Currently, the application only allows for verifying ECDSA keys as it lacked support for attesting RSA keys within the Android KeyStore. With this commit, it allows to perform a complete validation of the two currently supported asymmetric key types in the Android KeyStore. A new menu option "Attest RSA key" was added for this purpose. Additionally, when exporting the keychain in p7b format, the keystore's type will be included as part of the filename to differentiate between the ECDSA (current default) and RSA. Signed-off-by: linuxct <[email protected]>
This was referenced Jul 7, 2025
Merged
VisionR1
added a commit
that referenced
this pull request
Jul 24, 2025
Thanks @salvogiangri vvb2060#50 (comment) vvb2060#50 (comment) Also Update README.md for proper info about this fork & the strings for the new feature (see PR #4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @linuxct, for this useful feature.
I hope you don't mind, I borrowed your PR and merged it with my fork.
You can check if all good, because i make a mistake and merged it in 2 part.