Always enable the dotnet module.#222
Merged
plusvic merged 1 commit intoVirusTotal:masterfrom Jan 31, 2023
Merged
Conversation
When building prior to this commit the dotnet module would be disabled unless you explicitly asked for it. This is the opposite of what the default is in libyara. Fix it by always building the dotnet module. Tested with: ``` wxs@mbp yara-python % PYTHONPATH=build/lib.macosx-10.9-universal2-3.9 python3 -c 'import yara; print(yara.modules)' ['tests', 'pe', 'elf', 'math', 'time', 'console', 'string', 'dotnet', 'hash'] wxs@mbp yara-python % ``` Without this change the dotnet module would not be in the list.
plusvic
approved these changes
Jan 31, 2023
plusvic
added a commit
that referenced
this pull request
Feb 8, 2023
…yor. This argument has been removed in #222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building prior to this commit the dotnet module would be disabled unless you explicitly asked for it. This is the opposite of what the default is in libyara. Fix it by always building the dotnet module.
Tested with:
Without this change the dotnet module would not be in the list.