fix: Generic static This. #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
i know this is a while ago, but can you give an example of what was broken before? Since this is not maintained anymore, I am ingesting all fixes into my fork. This seems similar to lots of other typescript fixes that were already proposed and merged into my fork. Woudl love to add your fix too |
Contributor
Author
Collaborator
|
This looks reasonable. @max-kahnt-keylight could you follow up with another PR to use the same approach in all static this inferences? |
Contributor
Author
|
💚 Very much appreciated that you are getting back to this even though the issue currently doesn't haunt me personally. I created #2700 now. I am not sure if I will be able to test it reasonably and push its finalization, but I think it definitely makes sense to have this in all such places 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #2531.
Should probably be extended to be used in all static This inferences.